You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sj...@apache.org on 2023/02/15 21:10:17 UTC
[maven-resolver] 01/01: [MRESOLVER-287] Get rid of deprecated finalize methods
This is an automated email from the ASF dual-hosted git repository.
sjaranowski pushed a commit to branch MRESOLVER-287
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
commit bdb88278683ed1fefed26ec5874f9d6d2baaf4d7
Author: Slawomir Jaranowski <s....@gmail.com>
AuthorDate: Wed Feb 15 22:05:16 2023 +0100
[MRESOLVER-287] Get rid of deprecated finalize methods
---
.../connector/basic/BasicRepositoryConnector.java | 14 --------------
.../aether/named/support/NamedLockFactorySupport.java | 18 ------------------
2 files changed, 32 deletions(-)
diff --git a/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java b/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
index e7ff2e94..edbb3ff5 100644
--- a/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
+++ b/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
@@ -172,20 +172,6 @@ final class BasicRepositoryConnector
return executor;
}
- @Override
- protected void finalize()
- throws Throwable
- {
- try
- {
- close();
- }
- finally
- {
- super.finalize();
- }
- }
-
@Override
public void close()
{
diff --git a/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockFactorySupport.java b/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockFactorySupport.java
index 9b9a2b48..f1ae82cd 100644
--- a/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockFactorySupport.java
+++ b/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockFactorySupport.java
@@ -76,24 +76,6 @@ public abstract class NamedLockFactorySupport
} );
}
-
- @Override
- protected void finalize() throws Throwable
- {
- try
- {
- if ( !locks.isEmpty() )
- {
- // report leak
- logger.warn( "Lock leak, referenced locks still exist {}", locks );
- }
- }
- finally
- {
- super.finalize();
- }
- }
-
/**
* Implementations shall create and return {@link NamedLockSupport} for given {@code name}, this method must never
* return {@code null}.