You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ylemiesa57 (via GitHub)" <gi...@apache.org> on 2026/07/22 12:18:58 UTC
[PR] Fix SSHRemoteJobOperator cleanup validating against wrong base dir when remote_base_dir is customized [airflow]
ylemiesa57 opened a new pull request, #70233:
URL: https://github.com/apache/airflow/pull/70233
Picking this one up because it looked like a well contained bug and a good way to learn how the ssh provider's remote job cleanup works.
## What I changed
`SSHRemoteJobOperator` lets you set a custom `remote_base_dir` for where job files get created on the remote host. The job actually runs fine under that custom directory, but when the operator tries to clean up afterward, `_validate_job_dir()` in `remote_job.py` was always checking the job dir against the hardcoded `POSIX_DEFAULT_BASE_DIR`/`WINDOWS_DEFAULT_BASE_DIR` constants instead of whatever `remote_base_dir` was actually configured. So cleanup would raise a `ValueError` ("Expected path under ...") for anyone not using the default directory, even though nothing was actually wrong.
I gave `_validate_job_dir()`, `build_posix_cleanup_command()`, and `build_windows_cleanup_command()` an optional `base_dir` parameter, and `_cleanup_remote_job()` now passes `self.remote_base_dir` through so validation checks against the directory the job actually used. When `base_dir` isn't passed (or is `None`) it still falls back to the old default, so this shouldn't change behavior for anyone not customizing `remote_base_dir`.
## Testing
- `pytest tests/unit/ssh/utils/test_remote_job.py tests/unit/ssh/operators/test_ssh_remote_job.py` — 49 passed (46 existing + 3 new)
- Added 3 tests covering: a custom base_dir being accepted, a path outside a custom base_dir still being rejected, and the Windows equivalent
- Confirmed the new tests actually catch the bug by checking them against the old code first (they fail with a clear `TypeError`/would fail with the old `ValueError` behavior)
- `ruff check` and `ruff format --check` clean on the changed files
- `mypy` clean on the two changed source files
Still fairly new to the codebase so let me know if I should tweak anything, especially if there's a reason the validation was written against the fixed default in the first place.
Fixes #69813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SSHRemoteJobOperator cleanup validating against wrong base dir when remote_base_dir is customized [airflow]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@airflow.apache.org>.
github-actions[bot] closed pull request #70233: Fix SSHRemoteJobOperator cleanup validating against wrong base dir when remote_base_dir is customized
URL: https://github.com/apache/airflow/pull/70233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SSHRemoteJobOperator cleanup validating against wrong base dir when remote_base_dir is customized [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #70233:
URL: https://github.com/apache/airflow/pull/70233#issuecomment-5045680858
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SSHRemoteJobOperator cleanup validating against wrong base dir when remote_base_dir is customized [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #70233:
URL: https://github.com/apache/airflow/pull/70233#issuecomment-6457226071
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org