You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2017/08/29 08:20:09 UTC

svn commit: r1806535 - in /directory/studio/branches/studio-value/plugins/openldap.acl.editor: plugin.properties plugin.xml src/main/java/org/apache/directory/studio/openldap/config/acl/OpenLdapAclEditorPluginConstants.java

Author: elecharny
Date: Tue Aug 29 08:20:09 2017
New Revision: 1806535

URL: http://svn.apache.org/viewvc?rev=1806535&view=rev
Log:
o Get rid of Plugin_id in plugin.properties
o Removed the various ID defined in plugin.properties that are used only once

Modified:
    directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.properties
    directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.xml
    directory/studio/branches/studio-value/plugins/openldap.acl.editor/src/main/java/org/apache/directory/studio/openldap/config/acl/OpenLdapAclEditorPluginConstants.java

Modified: directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.properties
URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.properties?rev=1806535&r1=1806534&r2=1806535&view=diff
==============================================================================
--- directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.properties (original)
+++ directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.properties Tue Aug 29 08:20:09 2017
@@ -14,8 +14,12 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-Plugin_id=org.apache.directory.studio.openldap.config.acl.editor
-
+#---------------------------------------------------------------------------------------------------
+# The IDs used more than once
+#---------------------------------------------------------------------------------------------------
 CtxType_Template_id=org.apache.directory.studio.openldap.config.acl.templates
+
+#---------------------------------------------------------------------------------------------------
+# The I18n Strings
+#---------------------------------------------------------------------------------------------------
 CtxType_Template_name=OpenLDAP ACL

Modified: directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.xml
URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.xml?rev=1806535&r1=1806534&r2=1806535&view=diff
==============================================================================
--- directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.xml (original)
+++ directory/studio/branches/studio-value/plugins/openldap.acl.editor/plugin.xml Tue Aug 29 08:20:09 2017
@@ -21,9 +21,9 @@
 <plugin>
   <extension point="org.apache.directory.studio.valueeditors">
    <valueEditor
-     class="org.apache.directory.studio.openldap.config.acl.editor.OpenLdapAclValueEditor"
-     icon="resources/icons/editor.gif"
-     name="OpenLDAP ACL Editor">
+       class="org.apache.directory.studio.openldap.config.acl.editor.OpenLdapAclValueEditor"
+       icon="resources/icons/editor.gif"
+       name="OpenLDAP ACL Editor">
      <attribute attributeType="olcAccess" />
    </valueEditor>
   </extension>
@@ -31,8 +31,8 @@
   <extension point="org.eclipse.ui.editors.templates">
    <include file="resources/templates/templates.xml"/>
    <contextType
-     class="org.eclipse.jface.text.templates.TemplateContextType"
-     id="%CtxType_Template_id"
-     name="%CtxType_Template_name"/>
+       class="org.eclipse.jface.text.templates.TemplateContextType"
+       id="%CtxType_Template_id"
+       name="%CtxType_Template_name"/>
   </extension>
 </plugin>

Modified: directory/studio/branches/studio-value/plugins/openldap.acl.editor/src/main/java/org/apache/directory/studio/openldap/config/acl/OpenLdapAclEditorPluginConstants.java
URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-value/plugins/openldap.acl.editor/src/main/java/org/apache/directory/studio/openldap/config/acl/OpenLdapAclEditorPluginConstants.java?rev=1806535&r1=1806534&r2=1806535&view=diff
==============================================================================
--- directory/studio/branches/studio-value/plugins/openldap.acl.editor/src/main/java/org/apache/directory/studio/openldap/config/acl/OpenLdapAclEditorPluginConstants.java (original)
+++ directory/studio/branches/studio-value/plugins/openldap.acl.editor/src/main/java/org/apache/directory/studio/openldap/config/acl/OpenLdapAclEditorPluginConstants.java Tue Aug 29 08:20:09 2017
@@ -38,8 +38,7 @@ public final class OpenLdapAclEditorPlug
     }
 
     /** The plug-in ID */
-    public static String PLUGIN_ID = OpenLdapAclEditorPlugin.getDefault().getPluginProperties()
-        .getString( "Plugin_id" ); //$NON-NLS-1$
+    public static final String PLUGIN_ID = OpenLdapAclEditorPluginConstants.class.getPackage().getName();
 
     /** The ID for OpenLDAP ACL Template */
     public static String TEMPLATE_ID = OpenLdapAclEditorPlugin.getDefault().getPluginProperties()