[GitHub] [hadoop] arp7 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

[GitBox <gi...@apache.org>]

arp7 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.
URL: https://github.com/apache/hadoop/pull/670#discussion_r316384114
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
 ##########
 @@ -2683,6 +2683,14 @@ public void deleteS3Bucket(String s3BucketName) throws IOException {
    * {@inheritDoc}
    */
   public S3SecretValue getS3Secret(String kerberosID) throws IOException{
+    UserGroupInformation user = ProtobufRpcEngine.Server.getRemoteUser();
+
+    // Check whether user name passed is matching with the current user or not.
 
 Review comment:
   Why is this new check required?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org