You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/07/12 13:52:21 UTC

[GitHub] tinkerpop pull request #670: TINKERPOP-1552 (master) Gremlin .NET

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/670

    TINKERPOP-1552 (master) Gremlin .NET

    This is the follow-on pull request to #644 that merges those changes to master.  It required some additional work unfortunately so I formed a separate pull request. Note that there are still failing .NET integration tests.
    
    I also don't think we should merge this until TINKERPOP-1427 is merged to master which will mean another rebase for this pull request. 
    
    This pull request does not require a VOTE at this time - it's just here as a placeholder for collaboration until everything is ready.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1552-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #670
    
----
commit 37a2471932229ae6a4c1f5e5f3f2d3d25bbf7fd4
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-04-06T17:02:23Z

    Add Gremlin-CSharp and Gremlin-DotNet
    
    This adds Gremlin-CSharp (a C# GLV), together with a .NET driver. The
    driver is based on Gremlin.Net
    (https://github.com/FlorianHockmann/Gremlin.Net) with added support for
    GLVs and Gremlin-CSharp is auto generated, very similar to
    Gremlin-Python.
    This should fix TINKERPOP-1552.

commit 0cab22ede371b648985d1921cb62afd75b170be2
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-05-18T19:53:06Z

    TINKERPOP-1552 Added license to poms for dotnet

commit 980c774b3aa5d92fc9e3f16c4fbabaf751bf211a
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-05-18T20:42:16Z

    TINKERPOP-1552 Minor dev docs formatting

commit e2453a1802b3f0f91933e44d7ec5aa7b9a963c4b
Author: Jorge Bay Gondra <jo...@gmail.com>
Date:   2017-05-31T15:19:55Z

    C# GLV: Generics and enum generation

commit f61227bc6bc7969e74e854830ec8d4eec00efe5e
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-06T15:41:10Z

    Reorganize Gremlin-DotNet
    
    This merges the formerly three .NET projects into just one: Gremlin.Net. For more information see the discussion in TINKERPOP-1552.

commit 3f8d2f50122d4a04682ebe598bee28b5f37b813e
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-06T15:50:55Z

    Rename gremlin-csharp-generator to gremlin-dotnet-generator

commit 852ff1f699d3255c19524dff392ef634653fd7d7
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-06T17:03:09Z

    Fix method reference in XML comment

commit 090834347de1c27c1556b410aabd18368dad9968
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-08T15:50:31Z

    TINKERPOP-1552 Cleaned up the poms for the dotnet GLV
    
    Removed a bunch of uncessary declarations. Build still seems to work nicely after all the deleting and moving stuff around.

commit 339e293f0311bb84872ccce39ad96e393b8e789b
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-08T17:06:43Z

    TINKERPOP-1552 Added groovy-ant to csharp build
    
    Fixed a warning message in the build.

commit 1daf48b20de100e05f38202cdd1b3405fb16932a
Author: Jorge Bay Gondra <jo...@gmail.com>
Date:   2017-06-09T08:20:55Z

    Remove unintended comment

commit ca3da92801aa350ff2a6042ad149ab29040e3c64
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-09T14:14:49Z

    Minor code cleanup for Gremlin.Net
    
    This mainly removes explicit type casting that are now obsolete thanks to changes from the pull request #620. It also makes the Dictionary CSharpToJavaEnums in NamingConversions private to avoid direct access to it as GetEnumJavaName should be used instead.

commit 1fa9a601a9d8ca48b0b569ef0d59f60d0c8f78db
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-12T20:09:24Z

    Add support for authentication (Plain SASL) to Gremlin.Net

commit 21843ce422aecd4bcd6b0cab9825f737f6c06f46
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-13T17:07:55Z

    TINKERPOP-1552 Removed the dotnet generator module
    
    Moved GLV generation to the gremlin-dotnet pom and gmaveplus plugin.

commit 74f9115f2b90514121e012ac1f2665c88c09f216
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-15T13:09:58Z

    Improve comments in Gremlin-DotNet, especially for the GLV part

commit 73690217a04d6aa4fdb31e48ea209c626c229c80
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-15T16:25:56Z

    Clean-up Gremlin-DotNet project files
    
    This removes some obsolete configuration options and improves the package meta information. Especially the description was extended to reflect the current state of Gremlin-DotNet. This explanation can be removed as soon as the old Gremlin.Net driver is obsolete (probably when a first release version of Gremlin-DotNet is released).
    The version is now 3.2.5-beta1.

commit 8468f4211a16674decac2ad7fe15a3a3985a9b9f
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-15T17:00:38Z

    Let Gremlin-DotNet include the documentation comments
    
    Every build now generates an XML document containing the documentation comments which will be displayed to the user with IntelliSense. The warning about missing comments had to be disabled for some files as we currently just don't have comments for those.

commit 3c0abd00ef1182b38db11f826b51b2d62a98d3ff
Author: Florian Hockmann <fh...@florian-hockmann.de>
Date:   2017-06-16T14:49:12Z

    Re-enable warnings where they were disabled unnecessarily

commit a02c78b2fce3d6871c5390d8a379f1f0efedc2fe
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-21T13:12:17Z

    TINKERPOP-1552 Minor change to dev docs as project structure changed

commit 227448287c911d596ddc7a2b5929c1c6d8d243a8
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-23T17:07:45Z

    TINKERPOP-1552 Bump to 3.2.6 in gremlin-dotnet

commit 703e6f2461f176319227e2244c4cd9be2155bafe
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-23T19:43:40Z

    TINKERPOP-1552 Added basic deployment options for nuget
    
    Can't use the dotnet maven plugin on linux. it makes direct calls to nuget, which on linux requires mono. Used antrun plugin instead which is what was used with gremlin-python and works fine. Accomplished a basic push to the nuget staging environment. Still some bumps to sort out before this is good.

commit 25fd472e0af744c979a681d62d4413b12e44bec7
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-23T20:05:35Z

    TINKERPOP-1552 More consistent use of Gremlin.Net

commit 6457bb95581d937ff8b2e6404bbd3ad961f88e8b
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-28T15:45:17Z

    TINKERPOP-1552 Polish up nuget deploy to work with NuGet.Config

commit 6135a00208a55b8317085531291c9ef98e481ce2
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-28T16:42:09Z

    TINKERPOP-1552 Make csproj version match maven pom versions

commit 554595f2e4adf60de1c890b090490c5aa62997b3
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-28T17:22:08Z

    TINKERPOP-1552 Nuget publishing of SNAPSHOTs working now.
    
    It's a bit hokey, but it works. There are some problems in the toolchain that makes this less nice that the gremlin-python setup. I almost wonder if we shouldn't copy the whole gremlin-dot-net source to target and operate on it in isolation so that we dont' have to muck with the source controlled csproj file. I suppose what I have here will work for now. As long as the documentation I wrote is followed I don't see any problems popping up, but we'll see.

commit eebc95d49d6bab9cdd9e51dfbb1317dfe1a3b72e
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-29T11:03:03Z

    TINKERPOP-1552 Updated changelog

commit 79e37fb912ee7a8c15cddfedad57b961198c8963
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-06-29T11:08:24Z

    TINKERPOP-1552 Added a warning to docs about Gremlin.Net

commit cc522be287fc70eecc5dbcfadefaf30d98d1c659
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-07-05T15:51:01Z

    TINKERPOP-1552 Bumped to dotnet-dev-1.0.4

commit 426d141fda6f70f11e806b857111bb6d8c8e41a0
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-07-05T16:09:52Z

    TINKERPOP-1552 Put enums on separate lines for Gremlin.Net

commit 694b16ed5e5ce3328d9a74ceed2d4d0dea5f8cf0
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-07-12T11:49:49Z

    Merge branch 'TINKERPOP-1552' into tp32
    
    Conflicts:
    	CHANGELOG.asciidoc

commit facd592f2e1269543ce3df9e81a7e16cec15ccdc
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-07-12T11:53:04Z

    Merge branch 'tp32'
    
    Conflicts:
    	docker/Dockerfile
    	pom.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    Note that the #672 is out for review now. Once that's merged we can get this .NET branch rebased, get Gremlin.NET configurable for both GraphSON 2.0 and 3.0 and this body of work can be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    I was just trying to get it to compile/run when I did that change. The generation seems a bit brittle. Would be nice to see that stuff "just work" regardless of what API changes gremlin sees. 
    
    > Afterwards, we should look into ways to do .NET generation as deterministic as possible.
    
    agreed - let's save that for future work. i'd just like to get this code into mainline with as few additional changes as possible at this point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    I reverted back to 2.0 for the default for testing. Only two tests failing under than model now that i have the server configured right. Not sure why there's two failures though on 2.0. Still trying to figure it out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    I'm looking into the `g_V_HasXname_markoX_ValueMap_Next` failure on gremlin-dotnet, it looks like the generation process was producing:
    
    ```
    public GraphTraversal<S, IDictionary<string, E2>> ValueMap<E2>(params object[] args)
    ```
    
    and now:
    
    ```
    public GraphTraversal< S , IDictionary<object, E2> > ValueMap<E2> (params object[] args)
    ```
    
    for java, both signatures exists (with different parameters). The safest route would be to use a second type parameter:
    ```
    public GraphTraversal< S , IDictionary<K, V> > ValueMap<K, V> (params object[] args)
    ```
    I'll try to find a solution. Afterwards, we should look into ways to do .NET generation as deterministic as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    sorry @jorgebay  - that's the first time that's happened. i thought i had pulled your change but i must not have......


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    I've added support for GraphSON3 on the Gremlin .NET:
    - Added `GraphSON3Writer` and `GraphSON3Reader`.
    - Modified unit tests to run using GraphSON2 and GraphSON2.
    
    I'm getting a failures on the integration tests of the .NET GLV, that start with:
    ```
    [xUnit.net 00:00:01.2357664]   Starting:    Gremlin.Net.IntegrationTest
    [WARNING] Exception processing a script on request [RequestMessage{, requestId=bad279b8-6f42-4e47-ad08-a0343239bc1d, op='eval', processor='', args={gremlin=1, language=unknown}}].
    ```
    I don't understand what changed at protocol level (besides the mime type) to cause this issue.
    
    @FlorianHockmann @spmallette I will not able to dedicate time the following weeks to this. Feel free to adapt / override my changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    Just pushed a fix for one of the two failing tests on this branch (still running on graphson 2.0 at this time). It was an authentication configuration problem with Gremlin Server. No clue yet as to what the issue is with the other tests just yet.  Hoping that once the GraphSON 2.0 stuff all works we can try graphson 3.0. i guess i might even consider merging it all with just 2.0 support. we won't have an official release of gremlin-dotnet anyway, so full support of graphson 3.0 isn't super critical.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    I've reused the `methodsWithSpecificTypes` to generate `ValueMap()` with 2 type parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    just rebased on master and force pushed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---