You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/17 17:09:14 UTC
[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5084:
Duplicate likely nodes added when loop axis split unevenly
ANSHUMAN87 opened a new pull request #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084
1:> This PR handles duplicate likely nodes added when loop axis is split into non-divisible factors.
2:> The scenario is covered in the test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5084: Duplicate likely
nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-601863419
@yzhliu can you take a look? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5084: Duplicate likely
nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-604104881
Thanks @ANSHUMAN87 @MarisaKirisame @yzhliu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5084: Duplicate
likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-601547332
Gentle reminder : @tqchen, @zhiics, @MarisaKirisame
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5084:
Duplicate likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#discussion_r395450267
##########
File path: src/te/schedule/message_passing.cc
##########
@@ -556,6 +556,16 @@ void PassUpBoundCheck(const Stage& s,
}
}
+bool IsRangeSame(const Range input_1, const Range input_2) {
+ arith::Analyzer analyzer;
+ if (input_1.same_as(input_2)) return true;
+ if ( !analyzer.CanProve(input_1->min == input_2->min)
Review comment:
no need to have the space after "("
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5084: Duplicate
likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-601835778
@zhiics : Thanks for your comment! It is handled now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5084: Duplicate
likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-603636335
@yzhliu: Gentle reminder!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5084: Duplicate
likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-601871102
@MarisaKirisame : Thanks for your comment! It is handled now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics merged pull request #5084: Duplicate likely
nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
zhiics merged pull request #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull
request #5084: Duplicate likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
MarisaKirisame commented on a change in pull request #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#discussion_r395826286
##########
File path: src/te/schedule/message_passing.cc
##########
@@ -556,6 +556,16 @@ void PassUpBoundCheck(const Stage& s,
}
}
+bool IsRangeSame(const Range input_1, const Range input_2) {
+ arith::Analyzer analyzer;
+ if (input_1.same_as(input_2)) return true;
+ if (!analyzer.CanProve(input_1->min == input_2->min)
Review comment:
return analyzer.CanProve(...) && analyzer.CanProve(...)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5084: Duplicate
likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-602208690
@zhiics , @MarisaKirisame : Thanks for your review!
@yzhliu : Welcome for review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5084: Duplicate
likely nodes added when loop axis split unevenly
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly
URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-600192772
@tqchen , @zhiics, @MarisaKirisame
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services