You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/07/22 00:35:14 UTC
[jira] Created: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
replace`isAscending` bool with `reversed`
-----------------------------------------
Key: CASSANDRA-311
URL: https://issues.apache.org/jira/browse/CASSANDRA-311
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741007#action_12741007 ]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
We're not just renaming it; we're negating it.
To get the same as asc=true, you should pass reversed=false.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-311:
----------------------------------------
Assignee: Jonathan Ellis
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 311-v6.patch, cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736912#action_12736912 ]
Michael Greene commented on CASSANDRA-311:
------------------------------------------
Unfortunately I get a lot of rejects off a clean trunk. Can you rebase?
Interestingly, you're using a different version of the Thrift compiler; wonder how those changes will play out. The rest of the changes look right from a read-through.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740810#action_12740810 ]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
hmm, that doesn't apply for me with git-apply or patch. most of the failures are against src/java/org/apache/cassandra/db/filter/SSTableSliceIterator.java which hasn't changed since 332. did you upload the wrong file?
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741427#action_12741427 ]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
if anyone is working on this, speak up now or I will :)
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733873#action_12733873 ]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
this requires changing interfaces/cassandra.thrift, regenerating the java api (thrift -gen java), and going through the code looking for ascending/!ascending with !reversed/reversed.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-311:
-------------------------------------
Attachment: CASSANDRA-311-addendum.diff
Missed a small spot, as pointed out by Mark Lewandowski on the list.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 311-v6.patch, CASSANDRA-311-addendum.diff, cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Carl Byström (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Byström updated CASSANDRA-311:
-----------------------------------
Attachment: cassandra-311-v2.patch
Rebased against latest trunk.
Left out generated Thrift code as my compiler version seem to differ.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741004#action_12741004 ]
Bill de hOra commented on CASSANDRA-311:
----------------------------------------
{quote}the system (thrift) tests _should_ need to be updated. {quote}
In test_server.py
_verify_super_range
_verify_super
TestMutations.test_empty_slice_super
TestMutations.test_super_cf_remove_column
TestMutations.test_super_cf_remove_supercolumn
use a boolean for Cassandra.get_slice_super/6 and
_verify_batch
_verify_simple
_verify_range
TestMutations.test_empty_slice
TestMutations.test_cf_remove_column
TestMutations.test_cf_remove
TestMutations.test_super_cf_remove_supercolumn
use a boolean for Cassandra.get_slice/6
Since all that's happen wrt thrift is a renaming a boolean, I wouldn't expect these to fail.
{quote}
- reverseOrder = !((SliceFromReadCommand)command).isAscending;
+ reverseOrder = !((SliceFromReadCommand)command).reversed;
where the variable has been renamed but correctness has not been preserved.
{quote}
Works fine as it still a boolean assignment inside a method (albeit exposing fields like that is ugly). All the patches to date indicate this is a signature rename op. In case there's more to the ticket can you explain what you mean by correctness?
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741562#action_12741562 ]
Eric Evans commented on CASSANDRA-311:
--------------------------------------
Looks good. +1
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 311-v6.patch, cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Carl Byström (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Byström updated CASSANDRA-311:
-----------------------------------
Attachment: cassandra-311-v3.diff
Rebased once again. Hope this one will apply cleanly.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741844#action_12741844 ]
Hudson commented on CASSANDRA-311:
----------------------------------
Integrated in Cassandra #164 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/164/])
switch "!isAscending" for "reversed."
patch by jbellis, Carl Bystrom, and Bill de hOra. reviewed by Eric Evans for
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 311-v6.patch, CASSANDRA-311-addendum.diff, cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739549#action_12739549 ]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
Sorry, I missed the rebase notification in my inbox. I'm in the middle of CASSANDRA-332 now which messes with this code a bit but I will try to apply after that.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-311:
-------------------------------------
Component/s: Core
Fix Version/s: 0.4
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-311:
-------------------------------------
Attachment: 311-v6.patch
rebased and fixed.
will probably need another rebase after CASSANDRA-357, sigh :)
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 311-v6.patch, cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740938#action_12740938 ]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
the system tests are not updated, but they pass, which in this case means the patch is broken since the system (thrift) tests _should_ need to be updated.
a quick look shows one example
- reverseOrder = !((SliceFromReadCommand)command).isAscending;
+ reverseOrder = !((SliceFromReadCommand)command).reversed;
where the variable has been renamed but correctness has not been preserved.
since unit tests are passing that may mean there are other errors cancelling each other out. :)
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill de hOra updated CASSANDRA-311:
-----------------------------------
Attachment: CASSANDRA-311-v5.patch
{quote}hmm, that doesn't apply for me with git-apply or patch.{quote}
Looks like I messed up the generated v4. Attached v5 took for me with git-apply and git-am (against r802420).
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill de hOra updated CASSANDRA-311:
-----------------------------------
Attachment: CASSANDRA-311-v4.diff
updated Carl's patch to apply post CASSANDRA-332
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741364#action_12741364 ]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
warning: CASSANDRA-329 has been applied so the asc code that used to be in SequenceFile is in SSTableSliceIterator now.
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch, cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-311) replace`isAscending` bool with
`reversed`
Posted by "Carl Byström (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Byström updated CASSANDRA-311:
-----------------------------------
Attachment: cassandra-311-v1.patch
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.