[GitHub] [carbondata] ravipesala commented on a change in pull request #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment

[GitBox <gi...@apache.org>]

ravipesala commented on a change in pull request #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment
URL: https://github.com/apache/carbondata/pull/3427#discussion_r342425814
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
 ##########
 @@ -167,15 +167,22 @@ public static boolean isColumnMatches(boolean isTransactionalTable,
     // column ID but can have same column name
     if (tableColumn.getDataType().isComplexType() && !(tableColumn.getDataType().getId()
         == DataTypes.ARRAY_TYPE_ID)) {
-      if (tableColumn.getColumnId().equalsIgnoreCase(queryColumn.getColumnId())) {
+      if (tableColumn.getColumnId().equalsIgnoreCase(queryColumn.getColumnId()) || (
 
 Review comment:
   Can you override equals method of Column or add method inside a column to do this check. It is pretty repetitive and more prone to issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services