You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@aurora.apache.org by sanofi2104 <gi...@git.apache.org> on 2017/04/14 19:31:33 UTC

[GitHub] aurora pull request #23: Fix bug. Do not increase current_consecutive_succes...

GitHub user sanofi2104 opened a pull request:

    https://github.com/apache/aurora/pull/23

    Fix bug. Do not increase current_consecutive_successes if .healthchec\u2026

    The Health Check is succeeding when the .healthchecksnooze is present. But it should just snooze which means there shouldn't be any increase in consecutive successes or consecutive failures. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanofi2104/aurora hotfix/health_checker_snooze-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aurora/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 55962b021eb849fb3455a638669f05d8dbec835c
Author: Vladimir Khalatyan <vl...@hulu.com>
Date:   2017-04-14T18:51:40Z

    Fix bug. Do not increase current_consecutive_successes if .healthchecksnooze file present

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] aurora issue #23: Fix bug. Do not increase current_consecutive_successes if ...

Posted by sanofi2104 <gi...@git.apache.org>.

Github user sanofi2104 commented on the issue:

    https://github.com/apache/aurora/pull/23
  
    Thanks for the fast reply. Done! 
    https://reviews.apache.org/r/58462/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] aurora issue #23: Fix bug. Do not increase current_consecutive_successes if ...

Posted by jcohen <gi...@git.apache.org>.

Github user jcohen commented on the issue:

    https://github.com/apache/aurora/pull/23
  
    Unfortunately we're unable to accept patches via pull requests. Can you please submit this via Apache Reviewboard (details here: https://github.com/apache/aurora/blob/master/CONTRIBUTING.md#getting-your-reviewboard-account).
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---