[GitHub] [pulsar] jerrypeng edited a comment on pull request #6983: Added ability to add annotations to Connector Configs

[GitBox <gi...@apache.org>]

jerrypeng edited a comment on pull request #6983:
URL: https://github.com/apache/pulsar/pull/6983#issuecomment-631748364


   @srkukarni thinking more about it, I am wondering for sources and sinks whether the following interface is appropriate now that we formalized the concept of a connector config.
   
   ```
       void open(final Map<String, Object> config, SourceContext sourceContext) throws Exception;
   ```
   
   Since a connector will have a config class attached to it should we still have "Map<String, Object> config" as an argument or should we somehow just pass in the config POJO?
   
   Though not sure that is possible given we only allow developers to specify in the connector config class in "pulsar-io.yaml".  There is not way to use Java generics to automatically specify the type of the config argument.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org