You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/08/01 15:10:33 UTC

[PR] fix: isolate per-broker failure in cluster list [rocketmq-dashboard]

123123213weqw opened a new pull request, #745:
URL: https://github.com/apache/rocketmq-dashboard/pull/745

   ### Problem
   
   `ClusterServiceImpl.list()` fetched every broker's runtime stats inside one big `try` block:
   
   ```java
   for (Map.Entry<Long, String> brokerAddr : brokerData.getBrokerAddrs().entrySet()) {
       KVTable kvTable = mqAdminExt.fetchBrokerRuntimeStats(brokerAddr.getValue());
       brokerMasterSlaveMap.put(brokerAddr.getKey(), kvTable.getTable());
   }
   ```
   
   If **any one** broker is temporarily unreachable, `fetchBrokerRuntimeStats` throws, the exception propagates to the outer catch, and the entire Cluster page fails — even though all the other brokers are healthy and their data is available.
   
   ### Fix
   
   Fetch each broker's runtime stats in its own `try/catch` and skip the brokers that fail (logging a warning). This is consistent with how `DashboardCollectTask.collectBroker` already handles per-broker failures (it skips brokers whose stats cannot be fetched).
   
   ### Verification
   
   `mvn compiler:compile` passes (`BUILD SUCCESS`).
   
   ### Diff
   
   1 file changed, +7 / -2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Studio] Isolate broker failures in cluster list [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #745:
URL: https://github.com/apache/rocketmq-dashboard/pull/745#issuecomment-5252653913

   Closing: based on the legacy src/ layout, and the functionality is covered by the rewritten studio implementation. RocketMQDashboardProvider/ClusterProvider already isolate per-broker failures with try/catch + warn.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Studio] Isolate broker failures in cluster list [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #745: [Studio] Isolate broker failures in cluster list
URL: https://github.com/apache/rocketmq-dashboard/pull/745


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: isolate per-broker failure in cluster list [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #745:
URL: https://github.com/apache/rocketmq-dashboard/pull/745#issuecomment-5153316792

   ## PR Review for #745: fix: isolate per-broker failure in cluster list
   
   ### Summary
   This PR modifies 1 file(s) with +7/-2 lines changed.
   
   ### Changed Files
   - src/main/java/org/apache/rocketmq/dashboard/service/impl/ClusterServiceImpl.java
   
   ### Observations
   - PR author: @123123213weqw
   - Diff size: 1536 characters
   - 8 additions, 3 deletions in diff
   
   ### Next Steps
   A detailed code-level review requires the code engine. This is a structural overview only.
   Please verify correctness, thread safety, and backward compatibility manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org