[GitHub] [dolphinscheduler] zhangyongtian commented on a diff in pull request #14089: [Improvement-3400][Project Management] Add "all online" and "all offl…

["zhangyongtian (via GitHub)" <gi...@apache.org>]

zhangyongtian commented on code in PR #14089:
URL: https://github.com/apache/dolphinscheduler/pull/14089#discussion_r1193001642


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java:
##########
@@ -521,4 +521,15 @@ void saveOtherRelation(User loginUser, ProcessDefinition processDefinition, Map<
      * @return variables data
      */
     Map<String, Object> viewVariables(User loginUser, long projectCode, long code);
+
+    /**
+     * Batch release process definitions by code states.
+     *
+     * @param loginUser    Login user.
+     * @param projectCode  Project code.
+     * @param codeStates   Code states in JSON format.
+     * @return Result of the batch release process definitions.
+     */
+    Map<String, Object> batchReleaseProcessDefinitions(User loginUser, long projectCode, String codeStates);

Review Comment:
   Hello, thank you very much for your help. I initially wanted to use two methods to express it, until I saw the implementation method below.
   https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java#L384
   I feel that this method will be more general. Just pass in the corresponding process definition code and corresponding state, and you can process it in bulk and universally. Do you think so?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org