You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/30 06:53:05 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #353: YUNIKORN-985: Enforcing MaxRunningApps limit
codecov[bot] edited a comment on pull request #353:
URL: https://github.com/apache/incubator-yunikorn-core/pull/353#issuecomment-1015448880
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#353](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85bb115) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/137803a63bc84cd5dc6b08722bfafd116d40b25a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (137803a) will **increase** coverage by `0.05%`.
> The diff coverage is `70.52%`.
> :exclamation: Current head 85bb115 differs from pull request most recent head 9a07b2d. Consider uploading reports for the commit 9a07b2d to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 67.56% 67.62% +0.05%
==========================================
Files 64 67 +3
Lines 9006 9195 +189
==========================================
+ Hits 6085 6218 +133
- Misses 2685 2739 +54
- Partials 236 238 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/usergroup\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3VzZXJncm91cF9tYW5hZ2VyLmdv) | `53.96% <53.96%> (ø)` | |
| [pkg/scheduler/objects/user.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3VzZXIuZ28=) | `58.33% <58.33%> (ø)` | |
| [pkg/scheduler/objects/group.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2dyb3VwLmdv) | `70.00% <70.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.73% <75.86%> (+0.17%)` | :arrow_up: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.92% <92.59%> (+0.91%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [137803a...9a07b2d](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/353?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org