You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/20 11:27:54 UTC
Review Request 56848: AMBARI-20079.Unable to filter by job id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56848/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20079
https://issues.apache.org/jira/browse/AMBARI-20079
Repository: ambari
Description
-------
The issue was because the filtering was failing when there was no space between job and id in the filter term job id. The fix has enabed the user to search with both job id and jobid filter terms.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js e6f7ec8
Diff: https://reviews.apache.org/r/56848/diff/
Testing
-------
Manual testing
Thanks,
Padma Priya N
Re: Review Request 56848: AMBARI-20079.Unable to filter by job id
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56848/#review166135
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 20, 2017, 11:27 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56848/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 11:27 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20079
> https://issues.apache.org/jira/browse/AMBARI-20079
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue was because the filtering was failing when there was no space between job and id in the filter term job id. The fix has enabed the user to search with both job id and jobid filter terms.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js e6f7ec8
>
> Diff: https://reviews.apache.org/r/56848/diff/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56848: AMBARI-20079.Unable to filter by job id
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56848/#review166085
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 20, 2017, 11:27 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56848/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 11:27 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20079
> https://issues.apache.org/jira/browse/AMBARI-20079
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue was because the filtering was failing when there was no space between job and id in the filter term job id. The fix has enabed the user to search with both job id and jobid filter terms.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js e6f7ec8
>
> Diff: https://reviews.apache.org/r/56848/diff/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> Padma Priya N
>
>