[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12450: Register services after module started

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #12450:
URL: https://github.com/apache/dubbo/pull/12450#discussion_r1220890806


##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java:
##########
@@ -333,8 +337,18 @@ public <T> void reExport(Exporter<T> exporter, URL newInvokerUrl) {
      */
     @SuppressWarnings("unchecked")
     public <T> void reExport(final Invoker<T> originInvoker, URL newInvokerUrl) {
-        String key = getCacheKey(originInvoker);
-        ExporterChangeableWrapper<T> exporter = (ExporterChangeableWrapper<T>) bounds.get(key);
+        String providerUrlKey = getProviderUrlKey(originInvoker);
+        String registryUrlKey = getRegistryUrlKey(originInvoker);
+        Map<String, ExporterChangeableWrapper<?>> registryMap = bounds.get(providerUrlKey);

Review Comment:
   In the scenario of multiple registries(e.g. zk:2181, zk:2182), the providerUrlKeys are the same, but invokers are different.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org