You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2020/01/09 00:06:14 UTC
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14992
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
WIP: Testing python2/python3 backwards compatibility or impala-shell
Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
---
M shell/impala_client.py
M shell/impala_shell.py
M shell/option_parser.py
M shell/shell_output.py
4 files changed, 180 insertions(+), 112 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14992/2
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/impala_shell.py@22
PS3, Line 22: import pdb
flake8: F401 'pdb' imported but unused
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/impala_shell.py@40
PS3, Line 40: def pass_set_trace():
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/impala_shell.py@129
PS3, Line 129: class ImpalaShell(cmd.Cmd, object):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/impala_shell.py@355
PS3, Line 355: )
flake8: E501 line too long (91 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/impala_shell.py@865
PS3, Line 865: e
flake8: F841 local variable 'e' is assigned to but never used
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/shell_output.py
File shell/shell_output.py:
http://gerrit.cloudera.org:8080/#/c/14992/3/shell/shell_output.py@19
PS3, Line 19: import pdb
flake8: F401 'pdb' imported but unused
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 02:58:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5389/
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 07:38:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5382/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 00:36:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5388/
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 01:32:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5388/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 00:07:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
WIP: Testing python2/python3 backwards compatibility or impala-shell
Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
---
M shell/impala_client.py
M shell/impala_shell.py
M shell/option_parser.py
M shell/shell_output.py
4 files changed, 184 insertions(+), 113 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14992/3
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has abandoned this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Abandoned
See patch 15132
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5386/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 03:12:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Testing python2/python3 backwards compatibility or impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14992 )
Change subject: WIP: Testing python2/python3 backwards compatibility or impala-shell
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@22
PS2, Line 22: import pdb
flake8: F401 'pdb' imported but unused
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@40
PS2, Line 40: def pass_set_trace():
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@129
PS2, Line 129: class ImpalaShell(cmd.Cmd, object):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@355
PS2, Line 355: )
flake8: E501 line too long (91 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/impala_shell.py@865
PS2, Line 865: e
flake8: F841 local variable 'e' is assigned to but never used
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/shell_output.py
File shell/shell_output.py:
http://gerrit.cloudera.org:8080/#/c/14992/2/shell/shell_output.py@19
PS2, Line 19: import pdb
flake8: F401 'pdb' imported but unused
--
To view, visit http://gerrit.cloudera.org:8080/14992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a61b5d48e8a83463bab925237d7b90b8bb69e7
Gerrit-Change-Number: 14992
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 00:06:57 +0000
Gerrit-HasComments: Yes