You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2018/05/03 06:13:29 UTC

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18447#discussion_r185703059
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -653,6 +653,25 @@ setMethod("hash",
                 column(jc)
               })
     
    +#' data_type
    +#'
    +#' Returns the data type of a given column.
    +#'
    +#' @param x Column to get the data type.
    +#'
    +#' @rdname data_type
    +#' @name data_type
    +#' @family misc functions
    --- End diff --
    
    can you follow the pattern, like for "hash" above? we don't have individual rdname etc for each function


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org