You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joris van Lieshout <jv...@schubergphilis.com> on 2014/05/21 17:12:45 UTC

Review Request 21772: dnsmasq stops logging if logrotate creates the file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21772/
-----------------------------------------------------------

Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Hugo Trippaers.


Repository: cloudstack-git


Description
-------

If for some reason dnsmasq.log does not exist anymore logrotate will create it with nobody as owner. This will prevent dnsmasq deamon from logging to that file.

-rw-r-----  1 nobody  root      0 May 16 06:25 dnsmasq.log
-rw-r-----  1 dnsmasq root   6236 Apr 18 12:17 dnsmasq.log-20140419
-rw-r-----  1 dnsmasq root  31673 May 13 22:51 dnsmasq.log-20140514
-rw-r-----  1 dnsmasq root  15739 May 14 18:05 dnsmasq.log-20140515
-rw-r-----  1 dnsmasq root  16831 May 15 21:11 dnsmasq.log-20140516


Diffs
-----

  systemvm/patches/debian/config/etc/logrotate.d/dnsmasq 838415d3 

Diff: https://reviews.apache.org/r/21772/diff/


Testing
-------


Thanks,

Joris van Lieshout


Re: Review Request 21772: dnsmasq stops logging if logrotate creates the file

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21772/#review45230
-----------------------------------------------------------

Ship it!


c54ce3cafbc51febe71fb2a997dbfc8ac9167fb0

- daan Hoogland


On May 21, 2014, 3:12 p.m., Joris van Lieshout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21772/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 3:12 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> If for some reason dnsmasq.log does not exist anymore logrotate will create it with nobody as owner. This will prevent dnsmasq deamon from logging to that file.
> 
> -rw-r-----  1 nobody  root      0 May 16 06:25 dnsmasq.log
> -rw-r-----  1 dnsmasq root   6236 Apr 18 12:17 dnsmasq.log-20140419
> -rw-r-----  1 dnsmasq root  31673 May 13 22:51 dnsmasq.log-20140514
> -rw-r-----  1 dnsmasq root  15739 May 14 18:05 dnsmasq.log-20140515
> -rw-r-----  1 dnsmasq root  16831 May 15 21:11 dnsmasq.log-20140516
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/etc/logrotate.d/dnsmasq 838415d3 
> 
> Diff: https://reviews.apache.org/r/21772/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>