Re: [PR] Spark 3.3: Add RemoveDanglingDeletes action [iceberg]

["zinking (via GitHub)" <gi...@apache.org>]

zinking commented on code in PR #6581:
URL: https://github.com/apache/iceberg/pull/6581#discussion_r1469455133


##########
api/src/main/java/org/apache/iceberg/DeleteFiles.java:
##########
@@ -55,6 +55,17 @@ default DeleteFiles deleteFile(DataFile file) {
     return this;
   }
 
+  /**
+   * Delete a file tracked by a {@link DeleteFile} from the underlying table.
+   *
+   * @param file a DeleteFile to remove from the table
+   * @return this for method chaining
+   */
+  default DeleteFiles deleteFile(DeleteFile file) {
+    deleteFile(file.path());

Review Comment:
   This will not work, and needs to be changed to use the delete file specific API. and I'm surprised that UT didn't catch it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org