You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/04/25 08:35:19 UTC

[GitHub] [flink] zentol opened a new pull request, #22484: [FLINK-31934][rocksdb][tests] Remove mocking

zentol opened a new pull request, #22484:
URL: https://github.com/apache/flink/pull/22484

   Remove mocking from the rocksdb tests, that would fail out-of-the-box on Java 17.
   
   RocksDBInitTest was renamed to RocksDBInitITCase so it runs in a separate JVM, which ensures that rocksdb wasn't initialized beforehand by another test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #22484: [FLINK-31934][rocksdb][tests] Remove mocking

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #22484:
URL: https://github.com/apache/flink/pull/22484#issuecomment-1521829398

   IIRC those mocks didnt cause issues on Java 17 so to me they are out of scope of this ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #22484: [FLINK-31934][rocksdb][tests] Remove mocking

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #22484:
URL: https://github.com/apache/flink/pull/22484


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22484: [FLINK-31934][rocksdb][tests] Remove mocking

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22484:
URL: https://github.com/apache/flink/pull/22484#issuecomment-1521402033

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "54d1e53d06b10a093bcb534820af781f04d8488e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "54d1e53d06b10a093bcb534820af781f04d8488e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 54d1e53d06b10a093bcb534820af781f04d8488e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org