You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "cshuo (via GitHub)" <gi...@apache.org> on 2025/12/12 09:19:01 UTC
[PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
cshuo opened a new pull request, #17580:
URL: https://github.com/apache/hudi/pull/17580
### Describe the issue this Pull Request addresses
Support column stats prunning on metadata columns for flink reader, fixes https://github.com/apache/hudi/issues/17565
### Summary and Changelog
Support column stats prunning on metadata columns for flink reader
### Impact
Improve flink query performance when there is filter on metadata columns.
### Risk Level
low
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3646131538
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1220799097befb48a278f2576f5c43aae487a2f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169)
* 3e527e89274d9cfa1d1917fdf20b207ac444b478 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #17580:
URL: https://github.com/apache/hudi/pull/17580#discussion_r2618695782
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/prune/ColumnStatsProbe.java:
##########
@@ -142,4 +149,12 @@ private static Object getValAsJavaObj(RowData indexRow, int pos, LogicalType col
throw new UnsupportedOperationException("Unsupported type: " + colType);
}
}
+
+ /**
+ * Only the following metadata columns have column stats index:_hoodie_commit_time, _hoodie_record_key, _hoodie_partition_path
+ */
+ private static boolean isPrunableFilter(ResolvedExpression expression) {
+ String[] refs = ExpressionUtils.referencedColumns(Collections.singletonList(expression));
Review Comment:
tracked here: https://github.com/apache/hudi/issues/17598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3655066575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
}, {
"hash" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"triggerType" : "PUSH"
}, {
"hash" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239",
"triggerID" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 635ec9682f7818d6f1ce65024018ab52d5d87fa0 UNKNOWN
* b4c8307ec9c2cfe65ac26f35e8c917e81ac57947 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3655650386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
}, {
"hash" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"triggerType" : "PUSH"
}, {
"hash" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239",
"triggerID" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"triggerType" : "PUSH"
}, {
"hash" : "ff396f506b41efe865024946ee58206e4c75a4c5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10240",
"triggerID" : "ff396f506b41efe865024946ee58206e4c75a4c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 635ec9682f7818d6f1ce65024018ab52d5d87fa0 UNKNOWN
* ff396f506b41efe865024946ee58206e4c75a4c5 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10240)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3645639428
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1220799097befb48a278f2576f5c43aae487a2f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3654747393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
}, {
"hash" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"triggerType" : "PUSH"
}, {
"hash" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e527e89274d9cfa1d1917fdf20b207ac444b478 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171)
* 635ec9682f7818d6f1ce65024018ab52d5d87fa0 UNKNOWN
* b4c8307ec9c2cfe65ac26f35e8c917e81ac57947 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3646039344
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1220799097befb48a278f2576f5c43aae487a2f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3655169553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
}, {
"hash" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"triggerType" : "PUSH"
}, {
"hash" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239",
"triggerID" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"triggerType" : "PUSH"
}, {
"hash" : "ff396f506b41efe865024946ee58206e4c75a4c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff396f506b41efe865024946ee58206e4c75a4c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 635ec9682f7818d6f1ce65024018ab52d5d87fa0 UNKNOWN
* b4c8307ec9c2cfe65ac26f35e8c917e81ac57947 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239)
* ff396f506b41efe865024946ee58206e4c75a4c5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3646437085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e527e89274d9cfa1d1917fdf20b207ac444b478 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #17580:
URL: https://github.com/apache/hudi/pull/17580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3646126145
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1220799097befb48a278f2576f5c43aae487a2f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169)
* 3e527e89274d9cfa1d1917fdf20b207ac444b478 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3654739351
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
}, {
"hash" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e527e89274d9cfa1d1917fdf20b207ac444b478 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171)
* 635ec9682f7818d6f1ce65024018ab52d5d87fa0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3655219482
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
}, {
"hash" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"triggerType" : "PUSH"
}, {
"hash" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239",
"triggerID" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"triggerType" : "PUSH"
}, {
"hash" : "ff396f506b41efe865024946ee58206e4c75a4c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10240",
"triggerID" : "ff396f506b41efe865024946ee58206e4c75a4c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 635ec9682f7818d6f1ce65024018ab52d5d87fa0 UNKNOWN
* b4c8307ec9c2cfe65ac26f35e8c917e81ac57947 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239)
* ff396f506b41efe865024946ee58206e4c75a4c5 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10240)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #17580:
URL: https://github.com/apache/hudi/pull/17580#discussion_r2618430634
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/prune/ColumnStatsProbe.java:
##########
@@ -142,4 +149,12 @@ private static Object getValAsJavaObj(RowData indexRow, int pos, LogicalType col
throw new UnsupportedOperationException("Unsupported type: " + colType);
}
}
+
+ /**
+ * Only the following metadata columns have column stats index:_hoodie_commit_time, _hoodie_record_key, _hoodie_partition_path
+ */
+ private static boolean isPrunableFilter(ResolvedExpression expression) {
+ String[] refs = ExpressionUtils.referencedColumns(Collections.singletonList(expression));
Review Comment:
For regular data columns that didn't build col_stats index, the query will skip the whole data skipping if the filter contains such columns, there is no need to differentiate the metadata columns here, let's remove this and add a TODO for the general fix of the missing col_stats columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3654755936
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10169",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
}, {
"hash" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171",
"triggerID" : "3e527e89274d9cfa1d1917fdf20b207ac444b478",
"triggerType" : "PUSH"
}, {
"hash" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635ec9682f7818d6f1ce65024018ab52d5d87fa0",
"triggerType" : "PUSH"
}, {
"hash" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239",
"triggerID" : "b4c8307ec9c2cfe65ac26f35e8c917e81ac57947",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e527e89274d9cfa1d1917fdf20b207ac444b478 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10171)
* 635ec9682f7818d6f1ce65024018ab52d5d87fa0 UNKNOWN
* b4c8307ec9c2cfe65ac26f35e8c917e81ac57947 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10239)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Support column stats prunning on metadata columns for flink reader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17580:
URL: https://github.com/apache/hudi/pull/17580#issuecomment-3645632722
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1220799097befb48a278f2576f5c43aae487a2f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1220799097befb48a278f2576f5c43aae487a2f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1220799097befb48a278f2576f5c43aae487a2f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org