You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2018/07/13 20:25:29 UTC
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10944
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
......................................................................
IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
In addition to previous fix for IMPALA-7288, this patch would prevent
impala from crashing in case a code-path generates a malformed
handcrafted function which it then tries to finalize. Ideally this
would never happen since the code paths for generating handcrafted IRs
would never generate a malformed function.
Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
2 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10944/1
--
To view, visit http://gerrit.cloudera.org:8080/10944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 20:34:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2815/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 20:58:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10944 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
......................................................................
IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
In addition to previous fix for IMPALA-7288, this patch would prevent
impala from crashing in case a code-path generates a malformed
handcrafted function which it then tries to finalize. Ideally this
would never happen since the code paths for generating handcrafted IRs
would never generate a malformed function.
Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
Reviewed-on: http://gerrit.cloudera.org:8080/10944
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
2 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 14 Jul 2018 00:20:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 20:58:41 +0000
Gerrit-HasComments: No