You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/11/19 19:26:37 UTC

[GitHub] [hbase] charlesconnell commented on a diff in pull request #4888: HBASE-27496 Optionally limit the cumulative size of normalization plans produced by SimpleRegionNormalizer

charlesconnell commented on code in PR #4888:
URL: https://github.com/apache/hbase/pull/4888#discussion_r1027132066


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java:
##########
@@ -607,6 +609,39 @@ public void testNormalizerCannotMergeNonAdjacentRegions() {
     assertThat(plans, empty());
   }
 
+  @Test
+  public void testMergeSizeLimit() {

Review Comment:
   I can write a test but it will be flaky and fail sometimes through bad luck. `Collections.shuffle()` is not guaranteed to actually change item ordering.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org