You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/15 14:27:46 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5210: api: Add 'created' field to API response
Pearl1594 opened a new pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210
### Description
Fixes: https://github.com/apache/cloudstack/issues/5209
This PR adds 'created' field to the response of listing Networks, VPCs, Projects, NetworkOffering
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882278668
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-880740984
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882486159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#discussion_r671514475
##########
File path: api/src/main/java/com/cloud/network/NetworkProfile.java
##########
@@ -329,4 +330,10 @@ public String getRouterIpv6() {
return null;
}
+ @Override
+ public Date getCreated() {
+ // TODO Auto-generated method stub
Review comment:
I think that this comment could be removed. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882277195
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882486159
Thanks @davidjumani
@Pearl1594 can you please address the open comments? Look like minor changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882278172
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882494780
@nvazquez the comments have been addressed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-880740782
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883004247
@Pearl1594 @DaanHoogland please kick another round of packaging + test after PR #5218 is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#discussion_r670555986
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ProjectResponse.java
##########
@@ -207,6 +208,10 @@
@Param(description = "the total number of virtual machines running for this project", since = "4.2.0")
private Integer vmRunning;
+ @SerializedName(ApiConstants.CREATED)
Review comment:
@Pearl1594 add 'since' param to the new response field wherever applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882960531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883198639
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883239549
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882960531
<b>Trillian test result (tid-1311)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5210-t1311-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 79 look OK, 10 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 344.57 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 347.54 | test_routers_network_ops.py
test_03_ssvm_internals | `Failure` | 14.45 | test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.39 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.37 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.40 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.37 | test_templates.py
test_04_extract_template | `Failure` | 128.33 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_volume_usage | `Failure` | 787.40 | test_usage.py
test_10_attachAndDetach_iso | `Failure` | 1510.31 | test_vm_life_cycle.py
test_06_download_detached_volume | `Failure` | 425.91 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882494780
@nvazquez the comments have been addressed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882265555
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883706983
Merging based on approvals and test results, failure seems unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882486159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882265067
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883238766
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883238766
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883687895
<b>Trillian test result (tid-1322)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5210-t1322-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 88 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1031.25 | test_privategw_acl.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-880761473
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882781784
Thanks @Pearl1594, waiting for test results and should be to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#discussion_r671071192
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ProjectResponse.java
##########
@@ -207,6 +208,10 @@
@Param(description = "the total number of virtual machines running for this project", since = "4.2.0")
private Integer vmRunning;
+ @SerializedName(ApiConstants.CREATED)
+ @Param(description = "the date this project was created")
Review comment:
```suggestion
@Param(description = "the date this project was created", since = "4.16.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882960531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-883238766
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5210: api: Add 'created' field to API response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5210:
URL: https://github.com/apache/cloudstack/pull/5210#issuecomment-882494780
@nvazquez the comments have been addressed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org