You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/01/21 18:59:54 UTC

[GitHub] zeppelin pull request #1931: [ZEPPELIN-1894] Capture stdin/stdout on interpr...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/1931

    [ZEPPELIN-1894] Capture stdin/stdout on interpreter process creation and propagate to front-end when error

    ### What is this PR for?
    This PR captures stdin/stdout on interpreter process creation and propagate to front-end when error.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - Capture and propagate stdin/stdout
    * [x] - unittest
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1984
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1894

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1931
    
----
commit 947d18326bfa37ca8c6644f0c241758a3cf5cf55
Author: Lee moon soo <mo...@apache.org>
Date:   2017-01-21T18:55:26Z

    Propagate process creation error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1931: [ZEPPELIN-1984] Capture stdin/stdout on interpr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1931


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1931: [ZEPPELIN-1984] Capture stdin/stdout on interpreter pr...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1931
  
    Thanks @felixcheung @Tagar reviewing it.
    Merge to master if no further comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1931: [ZEPPELIN-1894] Capture stdin/stdout on interpreter pr...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/1931
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1931: [ZEPPELIN-1984] Capture stdin/stdout on interpreter pr...

Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:

    https://github.com/apache/zeppelin/pull/1931
  
    Tested today's master merged with #1931 and #1921 and it works great. LGTM 
    Thanks again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1931: [ZEPPELIN-1894] Capture stdin/stdout on interpreter pr...

Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:

    https://github.com/apache/zeppelin/pull/1931
  
    Thanks a lot @Leemoonsoo . 
    ps. PR title misspelled ZEPPELIN-1894 -> ZEPPELIN-1984


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---