You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2019/12/03 20:48:56 UTC

[royale-asjs] branch develop updated (6f9e876 -> 5d33708)

This is an automated email from the ASF dual-hosted git repository.

aharui pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.


    from 6f9e876  bugfix: Make sure that HTTPService does not cache the decoded json from the previous response.
     new ffa58b8  show close button.  Needs CSS to position correctly
     new 5d33708  handle 0 length collections better.  Should fix #601

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ...taItemRendererFactoryForICollectionViewAdvancedDataGridData.as | 8 ++++++--
 .../src/main/royale/spark/components/beads/PanelView.as           | 3 +++
 2 files changed, 9 insertions(+), 2 deletions(-)


[royale-asjs] 02/02: handle 0 length collections better. Should fix #601

Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 5d33708e5a31011c2fd729fb1892bba09e78eddb
Author: Alex Harui <ah...@apache.org>
AuthorDate: Tue Dec 3 12:48:40 2019 -0800

    handle 0 length collections better.  Should fix #601
---
 ...taItemRendererFactoryForICollectionViewAdvancedDataGridData.as | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as
index 49854dd..e711db8 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as
@@ -115,7 +115,7 @@ package mx.controls.advancedDataGridClasses
                 return;
             
             cursor = dp.createCursor();
-            currentIndex = 0;
+            currentIndex = (dp.length > 0) ? 0 : -1;
             
             // listen for individual items being added in the future.
             //var dped:IEventDispatcher = dp as IEventDispatcher;
@@ -206,7 +206,11 @@ package mx.controls.advancedDataGridClasses
                 UIBase(ir).percentWidth = 100;
             }
             var delta:int = index - currentIndex;
-            if (delta == -1)
+            if (currentIndex == -1)
+            {
+                cursor.seek(CursorBookmark.FIRST, index);                
+            }
+            else if (delta == -1)
             {
                 cursor.movePrevious();
             }


[royale-asjs] 01/02: show close button. Needs CSS to position correctly

Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit ffa58b856163b1d3e7a8d81771e0785fed7028d5
Author: Alex Harui <ah...@apache.org>
AuthorDate: Tue Dec 3 12:48:11 2019 -0800

    show close button.  Needs CSS to position correctly
---
 .../SparkRoyale/src/main/royale/spark/components/beads/PanelView.as    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/PanelView.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/PanelView.as
index 16bc209..44485f1 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/PanelView.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/PanelView.as
@@ -65,6 +65,9 @@ public class PanelView extends org.apache.royale.html.beads.PanelView
     {
         titleBar = new PanelTitleBar();
         super.strand = value;
+        var host:SkinnableContainer = _strand as SkinnableContainer;
+        var model:PanelModel = host.model as PanelModel;
+        model.showCloseButton = true;
     }
     
     /**