You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2007/03/29 02:20:25 UTC

[jira] Created: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

getvariation() is called from webpage constructor through commoninit()
----------------------------------------------------------------------

                 Key: WICKET-432
                 URL: https://issues.apache.org/jira/browse/WICKET-432
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.2.5
            Reporter: Igor Vaynberg
             Fix For: 1.3


getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 

getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485038 ] 

Eelco Hillenius commented on WICKET-432:
----------------------------------------

+1 on that.

> getvariation() is called from webpage constructor through commoninit()
> ----------------------------------------------------------------------
>
>                 Key: WICKET-432
>                 URL: https://issues.apache.org/jira/browse/WICKET-432
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Igor Vaynberg
>             Fix For: 1.3
>
>
> getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 
> getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-432:
------------------------------------

    Assignee: Igor Vaynberg

> getvariation() is called from webpage constructor through commoninit()
> ----------------------------------------------------------------------
>
>                 Key: WICKET-432
>                 URL: https://issues.apache.org/jira/browse/WICKET-432
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Igor Vaynberg
>         Assigned To: Igor Vaynberg
>             Fix For: 1.2.6, 1.3
>
>
> getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 
> getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-432.
----------------------------------

    Resolution: Fixed

> getvariation() is called from webpage constructor through commoninit()
> ----------------------------------------------------------------------
>
>                 Key: WICKET-432
>                 URL: https://issues.apache.org/jira/browse/WICKET-432
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Igor Vaynberg
>         Assigned To: Igor Vaynberg
>             Fix For: 1.2.6, 1.3
>
>
> getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 
> getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485036 ] 

Igor Vaynberg commented on WICKET-432:
--------------------------------------

in fact now that we have great support for onload events in IHeaderContributor we can think about removing bodycontainer altogether as iheadercontributor is a much better solution

> getvariation() is called from webpage constructor through commoninit()
> ----------------------------------------------------------------------
>
>                 Key: WICKET-432
>                 URL: https://issues.apache.org/jira/browse/WICKET-432
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Igor Vaynberg
>             Fix For: 1.3
>
>
> getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 
> getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-432:
---------------------------------

    Fix Version/s: 1.2.6

so in 1.3 we can remove it, but in 1.2 we need to fix this problem

> getvariation() is called from webpage constructor through commoninit()
> ----------------------------------------------------------------------
>
>                 Key: WICKET-432
>                 URL: https://issues.apache.org/jira/browse/WICKET-432
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Igor Vaynberg
>             Fix For: 1.2.6, 1.3
>
>
> getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 
> getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485692 ] 

Igor Vaynberg commented on WICKET-432:
--------------------------------------

1.2.6 fix is done

> getvariation() is called from webpage constructor through commoninit()
> ----------------------------------------------------------------------
>
>                 Key: WICKET-432
>                 URL: https://issues.apache.org/jira/browse/WICKET-432
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Igor Vaynberg
>             Fix For: 1.2.6, 1.3
>
>
> getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 
> getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-432) getvariation() is called from webpage constructor through commoninit()

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485042 ] 

Matej Knopp commented on WICKET-432:
------------------------------------

+1 as well

> getvariation() is called from webpage constructor through commoninit()
> ----------------------------------------------------------------------
>
>                 Key: WICKET-432
>                 URL: https://issues.apache.org/jira/browse/WICKET-432
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Igor Vaynberg
>             Fix For: 1.3
>
>
> getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems. 
> getvariation should not be called from WebPage constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.