You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2013/05/05 18:22:16 UTC

[jira] [Commented] (COLLECTIONS-455) AbstractDualBidiMap has several mutable protected fields

    [ https://issues.apache.org/jira/browse/COLLECTIONS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649367#comment-13649367 ] 

Thomas Neidhart commented on COLLECTIONS-455:
---------------------------------------------

Are you done with the changes or is something still missing?
                
> AbstractDualBidiMap<K, V> has several mutable protected fields
> --------------------------------------------------------------
>
>                 Key: COLLECTIONS-455
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-455
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 4.0
>
>
> Any non-private mutable fields make it much harder to ensure thread-safety as well as making it very difficult to test thoroughly.
> The fields should be made private.
> If protected write access really is needed, setter methods should be used.
> These methods can take any necessary precautions to ensure thread-safety.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira