[GitHub] [calcite] amansinha100 edited a comment on issue #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

[GitBox <gi...@apache.org>]

amansinha100 edited a comment on issue #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…
URL: https://github.com/apache/calcite/pull/1492#issuecomment-540268099
 
 
   Note to reviewer:  All except 1 test ran successfully.  In one of the tests  2 successive runs show slightly different diffs in the same test suite  which I don't really understand, so if you have any thoughts on this, let me know: 
   
   1st run: 
   ```
   [ERROR] Failures: 
   [ERROR]   CoreQuidemTest>QuidemTest.test:210->QuidemTest.checkRun:166 Files differ: /Users/asinha/optiq/core/target/test-classes/sql/surefire/sql/sub-query.iq /Users/asinha/optiq/core/target/test-classes/sql/sub-query.iq
   2102c2102
   < EnumerableCalc(expr#0..6=[{inputs}], expr#7=[>($t1, $t2)], expr#8=[IS TRUE($t7)], expr#9=[IS NULL($t5)], expr#10=[0], expr#11=[=($t3, $t10)], expr#12=[OR($t9, $t11)], expr#13=[IS NOT TRUE($t12)], expr#14=[AND($t8, $t13)], expr#15=[>($t3, $t4)], expr#16=[IS TRUE($t15)], expr#17=[null:BOOLEAN], expr#18=[IS NOT TRUE($t7)], expr#19=[AND($t16, $t17, $t13, $t18)], expr#20=[IS NOT TRUE($t15)], expr#21=[AND($t7, $t13, $t18, $t20)], expr#22=[OR($t14, $t19, $t21)], EMPNO=[$t0], EXPR$1=[$t22])
   ---
   > EnumerableCalc(expr#0..6=[{inputs}], expr#7=[IS NULL($t5)], expr#8=[false], expr#9=[0], expr#10=[=($t3, $t9)], expr#11=[>($t1, $t2)], expr#12=[IS TRUE($t11)], expr#13=[true], expr#14=[>($t3, $t4)], expr#15=[null:BOOLEAN], expr#16=[CASE($t7, $t8, $t10, $t8, $t12, $t13, $t14, $t15, $t11)], EMPNO=[$t0], EXPR$1=[$t16])
   ```
   
   2nd run: 
   ```
   CoreQuidemTest>QuidemTest.test:210->QuidemTest.checkRun:166 Files differ: /Users/asinha/optiq/core/target/test-classes/sql/surefire/sql/sub-query.iq /Users/asinha/optiq/core/target/test-classes/sql/sub-query.iq
   1575c1575
   < EnumerableCalc(expr#0..2=[{inputs}], expr#3=[true], expr#4=[10], expr#5=[=($t4, $t0)], cs=[$t3], $condition=[$t5])
   ---
   > EnumerableCalc(expr#0..2=[{inputs}], expr#3=[true], expr#4=[CAST($t0):TINYINT], expr#5=[null:TINYINT], expr#6=[CASE($t3, $t4, $t5)], expr#7=[IS NOT NULL($t6)], expr#8=[10], expr#9=[=($t8, $t0)], cs=[$t7], $condition=[$t9])
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services