You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/11/24 11:11:12 UTC
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1399
[FLINK-3067] Enforce zkclient 0.7 for Kafka
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1399
----
commit af4a553b640e1c3d8f39cfd8b5dc772f718cd794
Author: Robert Metzger <rm...@apache.org>
Date: 2015-11-24T10:09:28Z
[FLINK-3067] Enforce zkclient 0.7 for Kafka
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159229332
I added the dependencyManagement section again, just to make sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159565479
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159644979
merging to release-0.10 and master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159250129
This seems to solve the dependency issue for our project +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159224200
It seems that the `dependencyManagement` section is mainly intended to control our versions.
So with a dependencyManagement section, you can make sure that we are using the same zkclient across all our submodules (for all our declared zkclient dependencies).
Since we didn't declare a zkclient dependency for the flink-connector-kafka, the `dependencyManagement` doesn't have any effect for other projects.
See also: http://stackoverflow.com/questions/28312975/maven-dependencymanagement-version-ignored-in-transitive-dependencies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1399#issuecomment-159219322
Curious, why did the dependency management entry not work?
Right now, we have two versions in the dependencies, one by us, one transitive by Kafka. Is it well defined which one is chosen? To my understanding, that is where dependency management entries define which version is chosen. If the dependency management alone did not work, I would assume it should still stay for that reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3067] Enforce zkclient 0.7 for Kafka
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---