You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/24 02:47:04 UTC

[GitHub] [pulsar] wangjialing218 opened a new pull request #8674: Optimize imports to conform checkstyle

wangjialing218 opened a new pull request #8674:
URL: https://github.com/apache/pulsar/pull/8674


   ### Motivation
   Some packages build fail due to `ImportOrder` check fail by checkstyle.  Although these packages are excluded in `suppressions.xml` but still got `ImportOrder` check fail in my environment.
   
   ### Modifications
   Optimize imports for these package by IDEA using the Imports setting mentioned in #8556 
   1. Remove the blank line between imports.
   2. Reorder imports in  ascending
   3. Remove exclude pacakge in `suppressions.xml`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie merged pull request #8674: Optimize imports to conform checkstyle

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8674:
URL: https://github.com/apache/pulsar/pull/8674


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] wangjialing218 commented on pull request #8674: Optimize imports to conform checkstyle

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #8674:
URL: https://github.com/apache/pulsar/pull/8674#issuecomment-732667113


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #8674: Optimize imports to conform checkstyle

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8674:
URL: https://github.com/apache/pulsar/pull/8674#issuecomment-735523893


   @wangjialing218 Can you rebase it to the latest master?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org