Code coverage for Java code

[Mariia Mykhailova <ma...@microsoft.com>]

Hi,

Last week we've enabled Cobertura for our Java code, so we can measure the % of code covered by tests.
Turns out we're at 23% line coverage and 18% branch coverage overall (excluding examples code).
There are more detailed per-project and per-class reports available after running mvn cobertura:cobertura.

What are our next actions? Do we want to invest in increasing code coverage?
What should be our strategy for it, which projects and components to start with etc?

-Mariia

Re: Code coverage for Java code

[Andrew Chung <af...@gmail.com>]

Hi,

Echoing on this, there has also been a lack of tests on Interop functions
and whether or not the handlers are wired properly through Java to C# and
vice versa. For instance, we have just discovered this morning that due to
a typo (my mistake) in the Interop refactoring, the
DriverRestartFailedEvaluator has been invoked in place of the
FailedEvaluatorHandler, causing jobs to fail when a FailedEvaluator
arrives. This should have easily been discovered in a local client test on
the C# side.

I have created https://issues.apache.org/jira/browse/REEF-914 to address
this, please feel free to add sub-tasks as you see fit!

Thanks,
Andrew

On Tue, Nov 3, 2015 at 3:20 PM, Markus Weimer <ma...@weimo.de> wrote:

> Do these tools capture our end-to-end integration tests? I'd expect
> them to exercise many more of our code paths than directly visible.
>
> Markus
>
> On Tue, Nov 3, 2015 at 3:17 PM, Mariia Mykhailova
> <ma...@microsoft.com> wrote:
> > Hi,
> >
> > Last week we've enabled Cobertura for our Java code, so we can measure
> the % of code covered by tests.
> > Turns out we're at 23% line coverage and 18% branch coverage overall
> (excluding examples code).
> > There are more detailed per-project and per-class reports available
> after running mvn cobertura:cobertura.
> >
> > What are our next actions? Do we want to invest in increasing code
> coverage?
> > What should be our strategy for it, which projects and components to
> start with etc?
> >
> > -Mariia
>

Re: Code coverage for Java code

[Markus Weimer <ma...@weimo.de>]

Do these tools capture our end-to-end integration tests? I'd expect
them to exercise many more of our code paths than directly visible.

Markus

On Tue, Nov 3, 2015 at 3:17 PM, Mariia Mykhailova
<ma...@microsoft.com> wrote:
> Hi,
>
> Last week we've enabled Cobertura for our Java code, so we can measure the % of code covered by tests.
> Turns out we're at 23% line coverage and 18% branch coverage overall (excluding examples code).
> There are more detailed per-project and per-class reports available after running mvn cobertura:cobertura.
>
> What are our next actions? Do we want to invest in increasing code coverage?
> What should be our strategy for it, which projects and components to start with etc?
>
> -Mariia