You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/29 19:13:17 UTC
[GitHub] [incubator-druid] gianm commented on issue #7787: Web-console: Add
run keyboard short cut to sql-control
gianm commented on issue #7787: Web-console: Add run keyboard short cut to sql-control
URL: https://github.com/apache/incubator-druid/pull/7787#issuecomment-497072113
> Ok, that makes sense. Also could you please not force push as much. It is totally ok to just add a bunch of small commits. They will be squashed when the PR is merged.
Btw, in general in Druid we recommend avoiding force pushes, since they confuse the GitHub UI that shows reviewers what changed since their last review. It extends to incorporating changes from mast too, where we suggest using `git merge master` rather than `git rebase master` in order to avoid force pushes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org