You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "javanna (via GitHub)" <gi...@apache.org> on 2024/09/06 21:07:20 UTC

[PR] Deprecate FacetsCollector@search utility methods [lucene]

javanna opened a new pull request, #13737:
URL: https://github.com/apache/lucene/pull/13737

   These can now be replaced by the corresponding methods added to FacetsCollectorManager that accept a FacetsCollectorManager as last argument in place of a Collector
   
   This is the backport #13733 , minus the removal of the static methods which get instead deprecated in the 9x branch.
   
   Relates to #11041
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Deprecate FacetsCollector#search utility methods [lucene]

Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on code in PR #13737:
URL: https://github.com/apache/lucene/pull/13737#discussion_r1747783583


##########
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##########
@@ -54,4 +79,167 @@ public ReducedFacetsCollector(final Collection<FacetsCollector> facetsCollectors
           facetsCollector -> matchingDocs.addAll(facetsCollector.getMatchingDocs()));
     }
   }
+
+  /** Utility method, to search and also collect all hits into the provided {@link Collector}. */

Review Comment:
   Shoot, I think I missed this in the earlier review but looks like we need a small javadoc cleanup here (need to mention `FacetsCollectorManager` instead of `Collector` right?). Same comment applies to all the new methods. Sorry for overlooking that.
   
   I just updated these on `main` with a quick commit (dc47adbbe736ef55f56feb8d66dc768eaba05fff). Could you cherry-pick this down into the back-port as well (and feel free to tweak the language if you think of ways to improve on it). Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Deprecate FacetsCollector#search utility methods [lucene]

Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna merged PR #13737:
URL: https://github.com/apache/lucene/pull/13737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Deprecate FacetsCollector#search utility methods [lucene]

Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on code in PR #13737:
URL: https://github.com/apache/lucene/pull/13737#discussion_r1748020468


##########
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##########
@@ -54,4 +79,167 @@ public ReducedFacetsCollector(final Collection<FacetsCollector> facetsCollectors
           facetsCollector -> matchingDocs.addAll(facetsCollector.getMatchingDocs()));
     }
   }
+
+  /** Utility method, to search and also collect all hits into the provided {@link Collector}. */

Review Comment:
   good catch, I missed that. Will backport your commit!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org