You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/10/03 10:01:20 UTC

[PR] [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals` [spark]

beliefer opened a new pull request, #43200:
URL: https://github.com/apache/spark/pull/43200

   ### What changes were proposed in this pull request?
   This PR follows up https://github.com/apache/spark/pull/43187 and improve the test case.
   
   
   ### Why are the changes needed?
   Avoid create data set duplicately and enhance the readability of the test case.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   Just update the test cases.
   
   
   ### How was this patch tested?
   Test cases updated.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   'No'.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals` [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #43200:
URL: https://github.com/apache/spark/pull/43200#issuecomment-1746482344

   
   > I am neutral about the changes.
   
   OK. Let me revert the change you mentioned. But we can avoid create data set duplicately.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals` [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43200: [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals`
URL: https://github.com/apache/spark/pull/43200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals` [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #43200:
URL: https://github.com/apache/spark/pull/43200#issuecomment-1751550423

   @MaxGekk Could you take a review again ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals` [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43200:
URL: https://github.com/apache/spark/pull/43200#issuecomment-1751575347

   Let's just merge but I would avoid such change in general.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals` [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43200:
URL: https://github.com/apache/spark/pull/43200#issuecomment-1751575377

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-45385][SQL][TESTS][FOLLOWUP] Improve the test case for deprecate `spark.sql.parser.escapedStringLiterals` [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #43200:
URL: https://github.com/apache/spark/pull/43200#issuecomment-1751588085

   > Let's just merge but I would avoid such change in general.
   
   Yeah. It's a minor change. I will avoid the similar change ! Thank you !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org