You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/06 08:54:39 UTC

[GitHub] [rocketmq] CleverZiv commented on pull request #2346: [ISSUE #2338] Using commitLeastPages parameters and substituting 'lastCom…

CleverZiv commented on pull request #2346:
URL: https://github.com/apache/rocketmq/pull/2346#issuecomment-874584159


   > I don't think this fix is suitable,org.apache.rocketmq.store.MappedFile#isAbleToCommit returns true under three conditions
   > 
   > 1. this file is full
   > 2. more or equal than commitLeastPages pages have not committed
   > 3. commitLeastPages less than 0
   > 
   > this means commit action can be happened on these conditions,not just more or equal than commitLeastPages pages have not committed.so the origional judgement as following is ok
   > 
   > > writePos - this.committedPosition.get() > 0
   
   I agree with you. And I’m not sure if this is correct, it make me confused


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org