[GitHub] [kafka] rreddy-22 commented on pull request #14418: MINOR: Move TopicIdPartition class to server-common

["rreddy-22 (via GitHub)" <gi...@apache.org>]

rreddy-22 commented on PR #14418:
URL: https://github.com/apache/kafka/pull/14418#issuecomment-1739739962

   > Thanks for this PR @rreddy-22 . LGTM. I had a slightly orthogonal question , I see another class by the same name TopicIDPartition [here](https://github.com/apache/kafka/blob/7ba6d7a0b439cd7be7918b77c6b08425d6b37526/clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java#L25) within the clinets module. Ideally the users of that class should use the class from server-common since that's the intent I believe. We don't need to derail this PR but probably we can file another ticket which does the same. WDYT?
   
   Hey, so that class has topicId mapped to TopicPartition and here we just use integer partition so we can't reuse this class there. I agree though that two classes with the same name isn't good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org