You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/01/14 00:24:02 UTC
Review Request 29868: Kerberos wizard: Back button does not work on
Configure Kerberos page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29868/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-9114
https://issues.apache.org/jira/browse/AMBARI-9114
Repository: ambari
Description
-------
Along with fixing the primary issue of navigation for back button on Configure Kerberos page, this patch also makes changes in the popover description for the "Test Connectivity" button on this page.
Diffs
-----
ambari-web/app/controllers/main/admin/kerberos/step2_controller.js ae0cdff
ambari-web/app/messages.js b1e0ea8
ambari-web/app/routes/add_kerberos_routes.js 624db82
ambari-web/app/views/wizard/controls_view.js 7ac3511
Diff: https://reviews.apache.org/r/29868/diff/
Testing
-------
tested e2e on a live cluster.
**ambari-web unit test result with the patch:**
5237 tests complete (7 seconds)
60 tests pending
Thanks,
Jaimin Jetly
Re: Review Request 29868: Kerberos wizard: Back button does not work
on Configure Kerberos page
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29868/#review67972
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Jan. 13, 2015, 11:24 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29868/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 11:24 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-9114
> https://issues.apache.org/jira/browse/AMBARI-9114
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Along with fixing the primary issue of navigation for back button on Configure Kerberos page, this patch also makes changes in the popover description for the "Test Connectivity" button on this page.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js ae0cdff
> ambari-web/app/messages.js b1e0ea8
> ambari-web/app/routes/add_kerberos_routes.js 624db82
> ambari-web/app/views/wizard/controls_view.js 7ac3511
>
> Diff: https://reviews.apache.org/r/29868/diff/
>
>
> Testing
> -------
>
> tested e2e on a live cluster.
>
> **ambari-web unit test result with the patch:**
>
> 5237 tests complete (7 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 29868: Kerberos wizard: Back button does not work
on Configure Kerberos page
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29868/#review67971
-----------------------------------------------------------
ambari-web/app/routes/add_kerberos_routes.js
<https://reviews.apache.org/r/29868/#comment112060>
This is the fix that resolves the primary issue.
- Jaimin Jetly
On Jan. 13, 2015, 11:24 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29868/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 11:24 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-9114
> https://issues.apache.org/jira/browse/AMBARI-9114
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Along with fixing the primary issue of navigation for back button on Configure Kerberos page, this patch also makes changes in the popover description for the "Test Connectivity" button on this page.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js ae0cdff
> ambari-web/app/messages.js b1e0ea8
> ambari-web/app/routes/add_kerberos_routes.js 624db82
> ambari-web/app/views/wizard/controls_view.js 7ac3511
>
> Diff: https://reviews.apache.org/r/29868/diff/
>
>
> Testing
> -------
>
> tested e2e on a live cluster.
>
> **ambari-web unit test result with the patch:**
>
> 5237 tests complete (7 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>