You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/08 15:12:15 UTC

[GitHub] [flink] XComp opened a new pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

XComp opened a new pull request #13564:
URL: https://github.com/apache/flink/pull/13564


   ## What is the purpose of the change
   
   The fix is necessary since there is a possibility that a `ConcurrentModificationException` is thrown as described in FLINK-17341.
   
   ## Brief change log
   
   The solution includes switching from `Iterator` to a `Set` of `AllocationID`s:
   - Introduced `TaskSlotTable.getActiveTaskAllocationIdsPerJob(JobID)`
   - Replaced usage of `TaskSlotTable.getActiveSlots(JobID)` by `TaskSlotTable.getActiveTaskAllocationIdsPerJob(JobID)`
   - Removed `TaskSlotTable.getActiveSlots(JobID)` and `TaskSlotTable.AllocationIDIterator`
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `TaskSlotTableImplTest.testTryMarkSlotActive`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303",
       "triggerID" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29eb9920d726629cb5d7c3b0a1093e46393b65eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705638916


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c8deaa314d1ca5f93f66c45391a5ba0cb8d9fd22 (Thu Oct 08 15:14:53 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705638916






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XComp commented on a change in pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13564:
URL: https://github.com/apache/flink/pull/13564#discussion_r502515463



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableImpl.java
##########
@@ -200,6 +200,17 @@ public boolean isClosed() {
 		}
 	}
 
+	@Override
+	public Set<AllocationID> getActiveTaskAllocationIdsPerJob(JobID jobId) {
+		Iterator<TaskSlot<T>> taskSlotIterator = new TaskSlotIterator(jobId, TaskSlotState.ACTIVE);
+		Set<AllocationID> allocationIds = new HashSet<>();
+		while (taskSlotIterator.hasNext()) {
+			allocationIds.add(taskSlotIterator.next().getAllocationId());
+		}
+
+		return allocationIds;

Review comment:
       ```suggestion
   		return Sets.newHashSet(new TaskSlotIterator(jobId, TaskSlotState.ACTIVE))
   			.stream()
   			.map(TaskSlot::getAllocationId)
   			.collect(Collectors.toSet());
   ```
   The only other shorter way I can imagine is the one above. I just hesitated because it would mean iterating over the collection twice just to save a few lines.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XComp commented on a change in pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13564:
URL: https://github.com/apache/flink/pull/13564#discussion_r502515463



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableImpl.java
##########
@@ -200,6 +200,17 @@ public boolean isClosed() {
 		}
 	}
 
+	@Override
+	public Set<AllocationID> getActiveTaskAllocationIdsPerJob(JobID jobId) {
+		Iterator<TaskSlot<T>> taskSlotIterator = new TaskSlotIterator(jobId, TaskSlotState.ACTIVE);
+		Set<AllocationID> allocationIds = new HashSet<>();
+		while (taskSlotIterator.hasNext()) {
+			allocationIds.add(taskSlotIterator.next().getAllocationId());
+		}
+
+		return allocationIds;

Review comment:
       ```suggestion
   		return Sets.newHashSet(new TaskSlotIterator(jobId, TaskSlotState.ACTIVE))
   			.stream()
   			.map(TaskSlot::getAllocationId)
   			.collect(Collectors.toSet());
   ```
   The only other "shorter" way I can imagine is the one above. I just hesitated because it would mean iterating over the collection twice just to save a few lines.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303",
       "triggerID" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e50feab6bbfe6bd193c5830cbb31d9899df7f2af",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7322",
       "triggerID" : "e50feab6bbfe6bd193c5830cbb31d9899df7f2af",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc UNKNOWN
   * e50feab6bbfe6bd193c5830cbb31d9899df7f2af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7322) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann commented on a change in pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13564:
URL: https://github.com/apache/flink/pull/13564#discussion_r502462462



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableImpl.java
##########
@@ -200,6 +200,17 @@ public boolean isClosed() {
 		}
 	}
 
+	@Override
+	public Set<AllocationID> getActiveTaskAllocationIdsPerJob(JobID jobId) {
+		Iterator<TaskSlot<T>> taskSlotIterator = new TaskSlotIterator(jobId, TaskSlotState.ACTIVE);
+		Set<AllocationID> allocationIds = new HashSet<>();
+		while (taskSlotIterator.hasNext()) {
+			allocationIds.add(taskSlotIterator.next().getAllocationId());
+		}
+
+		return allocationIds;

Review comment:
       ```suggestion
   		return Sets.newHashSet(new TaskSlotIterator(jobId, TaskSlotState.ACTIVE);
   ```
   
   might be a bit shorter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann closed pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #13564:
URL: https://github.com/apache/flink/pull/13564


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XComp commented on a change in pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13564:
URL: https://github.com/apache/flink/pull/13564#discussion_r502515463



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableImpl.java
##########
@@ -200,6 +200,17 @@ public boolean isClosed() {
 		}
 	}
 
+	@Override
+	public Set<AllocationID> getActiveTaskAllocationIdsPerJob(JobID jobId) {
+		Iterator<TaskSlot<T>> taskSlotIterator = new TaskSlotIterator(jobId, TaskSlotState.ACTIVE);
+		Set<AllocationID> allocationIds = new HashSet<>();
+		while (taskSlotIterator.hasNext()) {
+			allocationIds.add(taskSlotIterator.next().getAllocationId());
+		}
+
+		return allocationIds;

Review comment:
       ```suggestion
   		return Sets.newHashSet(new TaskSlotIterator(jobId, TaskSlotState.ACTIVE))
   			.stream()
   			.map(TaskSlot::getAllocationId)
   			.collect(Collectors.toSet());
   ```
   The only other shorter way I can imagine is the one above. I just hesitated because it would mean iterating over the collection twice just to save a few lines.
   
   ```suggestion
   		return StreamSupport.stream(Spliterators.spliteratorUnknownSize(new TaskSlotIterator(jobId, TaskSlotState.ACTIVE), Spliterator.ORDERED), false)
   			.map(TaskSlot::getAllocationId)
   			.collect(Collectors.toSet());
   ```
   Creating a stream right out of the Iterator does not make the code more readable either, IMHO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303",
       "triggerID" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29eb9920d726629cb5d7c3b0a1093e46393b65eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303) 
   * 26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303",
       "triggerID" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e50feab6bbfe6bd193c5830cbb31d9899df7f2af",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e50feab6bbfe6bd193c5830cbb31d9899df7f2af",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29eb9920d726629cb5d7c3b0a1093e46393b65eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303) 
   * 26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc UNKNOWN
   * e50feab6bbfe6bd193c5830cbb31d9899df7f2af UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303",
       "triggerID" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e50feab6bbfe6bd193c5830cbb31d9899df7f2af",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7322",
       "triggerID" : "e50feab6bbfe6bd193c5830cbb31d9899df7f2af",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29eb9920d726629cb5d7c3b0a1093e46393b65eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303) 
   * 26b91f610ae3adfa35b1f6b9ac5d60d6ff598cfc UNKNOWN
   * e50feab6bbfe6bd193c5830cbb31d9899df7f2af Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7322) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29eb9920d726629cb5d7c3b0a1093e46393b65eb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann commented on a change in pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13564:
URL: https://github.com/apache/flink/pull/13564#discussion_r502519775



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableImpl.java
##########
@@ -200,6 +200,17 @@ public boolean isClosed() {
 		}
 	}
 
+	@Override
+	public Set<AllocationID> getActiveTaskAllocationIdsPerJob(JobID jobId) {
+		Iterator<TaskSlot<T>> taskSlotIterator = new TaskSlotIterator(jobId, TaskSlotState.ACTIVE);
+		Set<AllocationID> allocationIds = new HashSet<>();
+		while (taskSlotIterator.hasNext()) {
+			allocationIds.add(taskSlotIterator.next().getAllocationId());
+		}
+
+		return allocationIds;

Review comment:
       Yes, you are completely right. Forget about my comment. I overlooked that we are only interested in the `AllocationIDs`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13564: [FLINK-17341][runtime] Fixed ConcurrentModificationException in TaskExecutor

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13564:
URL: https://github.com/apache/flink/pull/13564#issuecomment-705651851


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303",
       "triggerID" : "29eb9920d726629cb5d7c3b0a1093e46393b65eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29eb9920d726629cb5d7c3b0a1093e46393b65eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7303) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org