You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by doychin <gi...@git.apache.org> on 2019/01/02 12:30:50 UTC

[GitHub] tomee pull request #344: On Windows getJarLocation returns path like x:\tome...

GitHub user doychin opened a pull request:

    https://github.com/apache/tomee/pull/344

    On Windows getJarLocation returns path like x:\tomee\bla\bla\bla

    This is not ok for the code that uses this path and tries to convert it to URL.
    
    For that reason a valid URL string must be returned from this method.
    
    Also the cycle below cycles on ejb modules but generates result from appModule which is already covered before that. Am I wrong here on my assumption?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/doychin/tomee jpa-on-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #344
    
----
commit ef70d15575ce88fda8757611cff2355205c1f9ab
Author: Doychin Bondzhev <do...@...>
Date:   2019-01-02T12:30:14Z

    On Windows getJarLocation returns path like x:\tomee\bla\bla\bla
    This is not ok for the code that uses this path and tries to convert it to URL.
    
    For that reason a valid URL string must be returned from this method.
    
    Also the cycle below cycles on ejb modules but generates result from appModule which is already covered before that. Am I wrong here on my assumption?

----


---