You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pedro-martins <gi...@git.apache.org> on 2015/12/19 18:07:41 UTC
[GitHub] cloudstack pull request: Removed methods from EventBus interface.
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/1260
Removed methods from EventBus interface.
Was removed the methods
. org.apache.cloudstack.framework.events.EventBus.subscribe(EventTopic, EventSubscriber)
. org.apache.cloudstack.framework.events.EventBus.unsubscribe(UUID, EventSubscriber)
from interface org.apache.cloudstack.framework.events.EventBus and it respective implementations org.apache.cloudstack.mom.inmemory.InMemoryEventBus, org.apache.cloudstack.mom.kafka.KafkaEventBus and org.apache.cloudstack.mom.rabbitmq.RabbitMQEventBus
because these methods are not used in cloudstack classpath, just in some test cases and these tests cases are removed too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack lrg-cs-hackday-017
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1260
----
commit 1e646daec230efc651ad4e85099d50176ee26f00
Author: pedro-martins <ph...@gmail.com>
Date: 2015-12-19T17:02:19Z
Removed methods from EventBus interface.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...
Posted by pedro-martins <gi...@git.apache.org>.
Github user pedro-martins closed the pull request at:
https://github.com/apache/cloudstack/pull/1260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1260#issuecomment-166691207
Did you try rebuilding CS with each type of event queue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1260#discussion_r48411330
--- Diff: plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java ---
@@ -58,34 +58,6 @@ public void setName(String name) {
}
@Override
- public UUID subscribe(EventTopic topic, EventSubscriber subscriber) throws EventBusException {
- if (subscriber == null || topic == null) {
- throw new EventBusException("Invalid EventSubscriber/EventTopic object passed.");
- }
- UUID subscriberId = UUID.randomUUID();
-
- subscribers.put(subscriberId, new Pair<EventTopic, EventSubscriber>(topic, subscriber));
- return subscriberId;
- }
-
- @Override
- public void unsubscribe(UUID subscriberId, EventSubscriber subscriber) throws EventBusException {
- if (subscriberId == null) {
- throw new EventBusException("Cannot unregister a null subscriberId.");
- }
-
- if (subscribers.isEmpty()) {
- throw new EventBusException("There are no registered subscribers to unregister.");
- }
-
- if (!subscribers.containsKey(subscriberId)) {
- throw new EventBusException("No subscriber found with subscriber id " + subscriberId);
- } else {
- subscribers.remove(subscriberId);
- }
- }
-
- @Override
--- End diff --
@pedro-martins Are you sure that this not used anywhere? The publish() method relies that 'subscribers' is not empty. And 'subscribers' is populated only in subscribe(). So as per the code I am sure it is getting used but not directly invoked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1260#issuecomment-204004213
@bvbharat I see that a test failed; I checked the logs and it seems that it was because it failed to apply the port forwarding rule. However, I could not find anything else (more details about the errors).
Could you help us to track if the failure is really due to the code changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1260#issuecomment-203678826
### ACS CI BVT Run
**Sumarry:**
Build Number 149
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=1
Skipped=4
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* <nose.suite
* ContextSuite context=TestScaleVm>:setup Failed
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso
**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---