[GitHub] [spark] shuyouZZ commented on a diff in pull request #42378: [SPARK-44703][CORE] Log eventLog rewrite duration when compact old event log files

["shuyouZZ (via GitHub)" <gi...@apache.org>]

shuyouZZ commented on code in PR #42378:
URL: https://github.com/apache/spark/pull/42378#discussion_r1286636112


##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileCompactor.scala:
##########
@@ -158,6 +159,8 @@ class EventLogFileCompactor(
       )
     }
     logWriter.stop()
+    val duration = System.currentTimeMillis() - startTime

Review Comment:
   I see, using `Utils.timeTakenMs` is also a good choice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org