You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/01 12:14:28 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6188: arch: Move -fstack-protector-all and -finstrument-functions from Make.defs to Toolchain.defs

pkarashchenko commented on code in PR #6188:
URL: https://github.com/apache/incubator-nuttx/pull/6188#discussion_r862465880


##########
arch/arm/src/armv8-m/Toolchain.defs:
##########
@@ -77,6 +77,13 @@ else
   ARCHOPTIMIZATION += -fomit-frame-pointer
 endif
 
+ifeq ($(CONFIG_STACK_CANARIES),y)
+  ARCHOPTIMIZATION += -fstack-protector-all

Review Comment:
   ```suggestion
     ARCHOPTIMIZATION += -fstack-protector-all
   endif
   ```
   



##########
arch/arm/src/armv7-m/Toolchain.defs:
##########
@@ -77,6 +77,13 @@ else
   ARCHOPTIMIZATION += -fomit-frame-pointer
 endif
 
+ifeq ($(CONFIG_STACK_CANARIES),y)
+  ARCHOPTIMIZATION += -fstack-protector-all

Review Comment:
   ```suggestion
     ARCHOPTIMIZATION += -fstack-protector-all
   endif
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org