You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/15 18:55:55 UTC
[GitHub] [nifi] jfrazee commented on a change in pull request #4460: NIFI-7717 Updated main NiFi images to JRE 11.
jfrazee commented on a change in pull request #4460:
URL: https://github.com/apache/nifi/pull/4460#discussion_r576373673
##########
File path: nifi-docker/dockerhub/Dockerfile
##########
@@ -15,8 +15,8 @@
# specific language governing permissions and limitations
# under the License.
#
-
-FROM openjdk:8-jre
+ARG JAVA_VERSION
+FROM ${JAVA_VERSION}
Review comment:
```suggestion
ARG IMAGE_NAME=openjdk
ARG IMAGE_TAG=8-jre
ARG MAINTAINER="Apache NiFi <de...@nifi.apache.org>"
FROM ${IMAGE_NAME}:${IMAGE_TAG} AS artifactbase
```
##########
File path: nifi-docker/dockermaven/Dockerfile
##########
@@ -53,7 +54,7 @@ RUN mkdir -p ${NIFI_HOME}/conf \
&& mkdir -p ${NIFI_HOME}/state \
&& mkdir -p ${NIFI_LOG_DIR}
-FROM openjdk:8-jre
+FROM $JAVA_VERSION
Review comment:
```suggestion
FROM ${IMAGE_NAME}:${IMAGE_TAG}
```
##########
File path: nifi-docker/dockerhub/pom.xml
##########
@@ -37,6 +41,7 @@
</goals>
<configuration>
<buildArgs>
+ <JAVA_VERSION>${docker.java.version}</JAVA_VERSION>
Review comment:
```suggestion
<IMAGE_NAME>${docker.image.name}</IMAGE_NAME >
<IMAGE_TAG>${docker.image.tag}</IMAGE_TAG >
<MAINTAINER>${docker.maintainer}</MAINTAINER >
```
##########
File path: nifi-docker/dockerhub/pom.xml
##########
@@ -20,6 +20,10 @@
<artifactId>dockerhub</artifactId>
+ <properties>
+ <docker.java.version>openjdk:8-jre</docker.java.version>
Review comment:
```suggestion
<docker.image.name>openjdk</docker.image.name>
<docker.image.tag>8-jre</docker.image.tag>
<docker.maintainer><![CDATA[Apache NiFi <de...@nifi.apache.org>]]></docker.maintainer>
```
##########
File path: nifi-docker/dockerhub/Dockerfile
##########
@@ -15,8 +15,8 @@
# specific language governing permissions and limitations
# under the License.
#
-
-FROM openjdk:8-jre
+ARG JAVA_VERSION
+FROM ${JAVA_VERSION}
LABEL maintainer="Apache NiFi <de...@nifi.apache.org>"
Review comment:
```suggestion
LABEL maintainer="${MAINTAINER}"
```
##########
File path: nifi-docker/dockermaven/Dockerfile
##########
@@ -16,7 +16,8 @@
# under the License.
#
-FROM openjdk:8-jre AS artifactbase
+ARG JAVA_VERSION
+FROM $JAVA_VERSION AS artifactbase
Review comment:
```suggestion
ARG IMAGE_NAME=openjdk
ARG IMAGE_TAG=8-jre
ARG MAINTAINER="Apache NiFi <de...@nifi.apache.org>"
FROM ${IMAGE_NAME}:${IMAGE_TAG} AS artifactbase
```
##########
File path: nifi-docker/dockermaven/pom.xml
##########
@@ -20,6 +20,10 @@
<artifactId>dockermaven</artifactId>
+ <properties>
+ <docker.java.version>openjdk:8-jre</docker.java.version>
Review comment:
```suggestion
<docker.image.name>openjdk</docker.image.name>
<docker.image.tag>8-jre</docker.image.tag>
<docker.maintainer><![CDATA[Apache NiFi <de...@nifi.apache.org>]]></docker.maintainer>
```
##########
File path: nifi-docker/dockermaven/pom.xml
##########
@@ -37,6 +41,7 @@
</goals>
<configuration>
<buildArgs>
+ <JAVA_VERSION>${docker.java.version}</JAVA_VERSION>
Review comment:
```suggestion
<IMAGE_NAME>${docker.image.name}</IMAGE_NAME >
<IMAGE_TAG>${docker.image.tag}</IMAGE_TAG >
<MAINTAINER>${docker.maintainer}</MAINTAINER >
```
##########
File path: nifi-docker/dockermaven/Dockerfile
##########
@@ -53,7 +54,7 @@ RUN mkdir -p ${NIFI_HOME}/conf \
&& mkdir -p ${NIFI_HOME}/state \
&& mkdir -p ${NIFI_LOG_DIR}
-FROM openjdk:8-jre
+FROM $JAVA_VERSION
LABEL maintainer="Apache NiFi <de...@nifi.apache.org>"
Review comment:
```suggestion
LABEL maintainer="${MAINTAINER}"
```
##########
File path: nifi-docker/dockermaven/Dockerfile
##########
@@ -16,7 +16,8 @@
# under the License.
#
-FROM openjdk:8-jre AS artifactbase
+ARG JAVA_VERSION
+FROM $JAVA_VERSION AS artifactbase
LABEL maintainer="Apache NiFi <de...@nifi.apache.org>"
Review comment:
```suggestion
LABEL maintainer="${MAINTAINER}"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org