You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2026/07/23 01:53:29 UTC
[PR] Fix flaky `ShuffleBufferManagerTest.shuffleFlushThreshold` [uniffle]
wForget opened a new pull request, #2773:
URL: https://github.com/apache/uniffle/pull/2773
### What changes were proposed?
Replace transient memory assertions and fixed sleeps in `ShuffleBufferManagerTest.shuffleFlushThreshold` with Awaitility-based assertions that wait for stable `usedMemory` and `inFlushSize` values.
### Why are the changes needed?
The asynchronous flush may complete before the test checks the intermediate memory usage, causing failures such as:
```text
expected: <159> but was: <63>
```
The previous assertions depended on thread scheduling, while fixed sleeps could not guarantee that flush cleanup had completed.
### How was this patch tested?
Existing test.
----
Generated by Codex (GPT-5.6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1823] fix(test): Fix flaky `ShuffleBufferManagerTest.shuffleFlushThreshold` [uniffle]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang merged PR #2773:
URL: https://github.com/apache/uniffle/pull/2773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1823] fix(test): Fix flaky `ShuffleBufferManagerTest.shuffleFlushThreshold` [uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2773:
URL: https://github.com/apache/uniffle/pull/2773#issuecomment-5053615812
## Test Results
3 617 files ±0 3 617 suites ±0 7h 44m 39s ⏱️ + 2m 8s
1 265 tests ±0 1 254 ✅ +1 11 💤 ±0 0 ❌ - 1
18 055 runs ±0 18 018 ✅ +1 37 💤 ±0 0 ❌ - 1
Results for commit 0b2882a5. ± Comparison against base commit 20167ff1.
[test-results]:data:application/gzip;base64,H4sIANJ6YWoC/03MTQ6DIBCG4asY1l3A6AzYyzQomJD60yCsmt69SJWy/J6ZvG82udnu7N60JOStYXt0od4meh3ctiYBqWSfKN3D8SGA8JqPPY5jNuz+9nSvw0SRSbs5CS9gvd/8KT6uOas44jlLVnGhiv2yrbygquZdR8dtWVxIg/EBlAKNvcW+6ziRRUuA1hAmbklz0IMBwz5ftsoE7xUBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1823] fix(test): Fix flaky `ShuffleBufferManagerTest.shuffleFlushThreshold` [uniffle]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #2773:
URL: https://github.com/apache/uniffle/pull/2773#issuecomment-5067391247
Merged into master. Thanks @wForget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1823] fix(test): Fix flaky `ShuffleBufferManagerTest.shuffleFlushThreshold` [uniffle]
Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #2773:
URL: https://github.com/apache/uniffle/pull/2773#discussion_r3635072764
##########
server/src/test/java/org/apache/uniffle/server/buffer/ShuffleBufferManagerTest.java:
##########
@@ -623,31 +621,29 @@ public void shuffleFlushThreshold() throws Exception {
shuffleBufferManager.cacheShuffleData(appId, shuffleId, false, createData(0, 64));
assertEquals(96, shuffleBufferManager.getUsedMemory());
shuffleBufferManager.cacheShuffleData(appId, smallShuffleId, false, createData(0, 31));
- assertEquals(96 + 63, shuffleBufferManager.getUsedMemory());
Review Comment:
The flush might have already been completed before this assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org