Re: [PR] HIVE-29413: Avoid code duplication by updating getPartCols method for iceberg tables [hive]

["abstractdog (via GitHub)" <gi...@apache.org>]

abstractdog commented on code in PR #6337:
URL: https://github.com/apache/hive/pull/6337#discussion_r2909982861


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -609,25 +609,30 @@ public boolean equals(Object obj) {
     return true;
   }
 
-  public List<FieldSchema> getPartCols() {
+  public List<FieldSchema> getPartCols(boolean needNonNativeParts) {

Review Comment:
   while I like the purpose of this refactor, I would discourage you to use method with boolean flags, it's against clean code principles: what about introducing 2 separate methods with proper names?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org