You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/14 12:39:00 UTC

[GitHub] [pulsar] tomscut opened a new pull request #13292: [testclient] Multiple calls to printAggregatedStats result in inaccur…

tomscut opened a new pull request #13292:
URL: https://github.com/apache/pulsar/pull/13292


   
   Fixes [#ISSUE-13250](https://github.com/streamnative/pulsar/issues/3409)
   
   ### Motivation
   
   We repeatedly call `#printAggregatedStats` in those places, which ultimately calls `Record#getIntervalHistogram`. The `startTimestamp` and `endTimestamp` will be reset, which may result in inconsistent results of multiple access. 
   
   We should only call printAggregatedStats once inside `ShutdownHook`, like `PerformanceClient`.
   
   ```
   Runtime.getRuntime().addShutdownHook(new Thread(() -> {
       printAggregatedThroughput(start);
       printAggregatedStats();
   }));
   ```
   
   ### Modifications
   
   Remove redundant calls to `#printAggregatedStats`.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   - [ ] `doc-required` 
   - [x] `no-need-doc` 
   - [ ] `doc` 
    
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yuruguo removed a comment on pull request #13292: [testclient] Multiple calls to printAggregatedStats result in inaccur…

Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #13292:
URL: https://github.com/apache/pulsar/pull/13292#issuecomment-993567265


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #13292: [testclient] Multiple calls to printAggregatedStats result in inaccur…

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13292:
URL: https://github.com/apache/pulsar/pull/13292


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #13292: [testclient] Multiple calls to printAggregatedStats result in inaccur…

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #13292:
URL: https://github.com/apache/pulsar/pull/13292#issuecomment-993597378


   Thanks @merlimat and @yuruguo for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yuruguo commented on pull request #13292: [testclient] Multiple calls to printAggregatedStats result in inaccur…

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #13292:
URL: https://github.com/apache/pulsar/pull/13292#issuecomment-993567265


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org