You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/22 10:50:15 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #12732: [FLINK-18372][runtime] Fix NPE problem when a slot is offered before JM is connected to a RM
zhuzhurk commented on a change in pull request #12732:
URL: https://github.com/apache/flink/pull/12732#discussion_r443474443
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -561,7 +561,11 @@ private void tryFulfillSlotRequestOrMakeAvailable(AllocatedSlot allocatedSlot) {
allocatedSlots.add(pendingRequest.getSlotRequestId(), allocatedSlot);
pendingRequest.getAllocatedSlotFuture().complete(allocatedSlot);
- maybeRemapOrphanedAllocation(allocationIdOfRequest, allocatedSlot.getAllocationId());
+ // the allocation id can be null if the request was fulfilled by a slot directly offered
+ // by a reconnected TaskExecutor before the ResourceManager is connected
+ if (allocationIdOfRequest != null) {
Review comment:
Agreed. done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org