You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/17 13:14:59 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #12097: docs: update UPDATING.md with security simplification info
dpgaspar opened a new pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097#issuecomment-750170434
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=h1) Report
> Merging [#12097](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=desc) (ef0c332) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **increase** coverage by `0.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12097 +/- ##
==========================================
+ Coverage 63.06% 63.63% +0.57%
==========================================
Files 994 484 -510
Lines 49075 29763 -19312
Branches 4984 0 -4984
==========================================
- Hits 30950 18941 -12009
+ Misses 17925 10822 -7103
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.63% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [510 more](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=footer). Last update [93af329...ef0c332](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097#issuecomment-750170434
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=h1) Report
> Merging [#12097](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=desc) (ef0c332) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `0.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12097 +/- ##
==========================================
- Coverage 63.06% 62.82% -0.25%
==========================================
Files 994 994
Lines 49075 49075
Branches 4984 4984
==========================================
- Hits 30950 30832 -118
- Misses 17925 18043 +118
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.22% <ø> (ø)` | |
| python | `63.86% <ø> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.77% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=footer). Last update [93af329...ef0c332](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097#discussion_r546346826
##########
File path: UPDATING.md
##########
@@ -23,6 +23,16 @@ This file documents any backwards-incompatible changes in Superset and
assists people when migrating to a new version.
## Next
+- [12072](https://github.com/apache/incubator-superset/pull/12072): Security simplification (SIP-19) permission view name renamed to `Query` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12036](https://github.com/apache/incubator-superset/pull/12036): Security simplification (SIP-19) permission view name renamed to `Database` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12012](https://github.com/apache/incubator-superset/pull/12036): Security simplification (SIP-19) permission view name renamed to `Dashboard` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12061](https://github.com/apache/incubator-superset/pull/12061): Security simplification (SIP-19) permission view name renamed to `Log` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12000](https://github.com/apache/incubator-superset/pull/12000): Security simplification (SIP-19) permission view name renamed to `Dataset` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12014](https://github.com/apache/incubator-superset/pull/12014): Security simplification (SIP-19) permission view name renamed to `Annotation` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11981](https://github.com/apache/incubator-superset/pull/11981): Security simplification (SIP-19) permission view name renamed to `Chart` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11853](https://github.com/apache/incubator-superset/pull/11853): Security simplification (SIP-19) permission view name renamed to `ReportSchedule` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11856](https://github.com/apache/incubator-superset/pull/11856): Security simplification (SIP-19) permission view name renamed to `CssTemplate` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11764](https://github.com/apache/incubator-superset/pull/11764): Security simplification (SIP-19) permission view name renamed to `SavedQuery` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
Review comment:
To make these stand out as a single entry in the list, would it make sense to group these under one bullet Stating that SIP-19 security simplification has been done with the sub bullets referencing the individual perms?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097#issuecomment-750170434
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=h1) Report
> Merging [#12097](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=desc) (ef0c332) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12097 +/- ##
==========================================
- Coverage 63.06% 62.68% -0.38%
==========================================
Files 994 994
Lines 49075 49075
Branches 4984 4984
==========================================
- Hits 30950 30765 -185
- Misses 17925 18110 +185
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.22% <ø> (ø)` | |
| python | `63.63% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=footer). Last update [93af329...ef0c332](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097#discussion_r546788439
##########
File path: UPDATING.md
##########
@@ -23,6 +23,16 @@ This file documents any backwards-incompatible changes in Superset and
assists people when migrating to a new version.
## Next
+- [12072](https://github.com/apache/incubator-superset/pull/12072): Security simplification (SIP-19) permission view name renamed to `Query` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12036](https://github.com/apache/incubator-superset/pull/12036): Security simplification (SIP-19) permission view name renamed to `Database` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12012](https://github.com/apache/incubator-superset/pull/12036): Security simplification (SIP-19) permission view name renamed to `Dashboard` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12061](https://github.com/apache/incubator-superset/pull/12061): Security simplification (SIP-19) permission view name renamed to `Log` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12000](https://github.com/apache/incubator-superset/pull/12000): Security simplification (SIP-19) permission view name renamed to `Dataset` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [12014](https://github.com/apache/incubator-superset/pull/12014): Security simplification (SIP-19) permission view name renamed to `Annotation` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11981](https://github.com/apache/incubator-superset/pull/11981): Security simplification (SIP-19) permission view name renamed to `Chart` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11853](https://github.com/apache/incubator-superset/pull/11853): Security simplification (SIP-19) permission view name renamed to `ReportSchedule` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11856](https://github.com/apache/incubator-superset/pull/11856): Security simplification (SIP-19) permission view name renamed to `CssTemplate` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
+- [11764](https://github.com/apache/incubator-superset/pull/11764): Security simplification (SIP-19) permission view name renamed to `SavedQuery` with `can_read`, `can_write`. Automatic db migration to new set of permissions for all existing roles.
Review comment:
makes sense, updated @villebro what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097#issuecomment-750170434
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=h1) Report
> Merging [#12097](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=desc) (ef0c332) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `0.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12097 +/- ##
==========================================
- Coverage 63.06% 62.85% -0.21%
==========================================
Files 994 994
Lines 49075 49075
Branches 4984 4984
==========================================
- Hits 30950 30848 -102
- Misses 17925 18027 +102
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.22% <ø> (ø)` | |
| python | `63.91% <ø> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=footer). Last update [93af329...ef0c332](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12097: docs: update UPDATING.md with security simplification info
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12097:
URL: https://github.com/apache/incubator-superset/pull/12097#issuecomment-750170434
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=h1) Report
> Merging [#12097](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=desc) (ef0c332) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **increase** coverage by `0.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12097 +/- ##
==========================================
+ Coverage 63.06% 63.60% +0.53%
==========================================
Files 994 484 -510
Lines 49075 29761 -19314
Branches 4984 0 -4984
==========================================
- Hits 30950 18929 -12021
+ Misses 17925 10832 -7093
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.60% <ø> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/incubator-superset/pull/12097/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=footer). Last update [93af329...ef0c332](https://codecov.io/gh/apache/incubator-superset/pull/12097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org