You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/30 09:22:21 UTC

[GitHub] [calcite] kgyrtkirk commented on a change in pull request #1340: [CALCITE-3192] Simplify OR incorrectly weaks condition

kgyrtkirk commented on a change in pull request #1340: [CALCITE-3192] Simplify OR incorrectly weaks condition
URL: https://github.com/apache/calcite/pull/1340#discussion_r308619372
 
 

 ##########
 File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
 ##########
 @@ -4955,7 +4955,7 @@ LogicalProject(EXPR$0=[1])
       LogicalProject(DEPTNO=[$7])
         LogicalFilter(condition=[>($7, 10)])
           LogicalTableScan(table=[[CATALOG, SALES, EMP]])
-    LogicalFilter(condition=[>($7, 7)])
+    LogicalFilter(condition=[OR(>($7, 7), >($7, 10))])
       LogicalTableScan(table=[[CATALOG, SALES, EMP]])
 ]]>
 
 Review comment:
   it could be; but this logic may not declare an inequality as a predicate - as that could introduce oversimplifications

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services